[stable18] dont hold a transaction during the move to trash

[backportbot-nextcloud]

⚠️ This backport had conflicts and is incomplete ⚠️ fixed

backport of #23109

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34334: failure

sqlite

Show full log

There was 1 error:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testRecipientDeleteInShare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:142
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mariadb10.1-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\UpdaterTest::testParentSize
Failed asserting that 0 matches expected 3.

/drone/src/tests/lib/Files/Cache/UpdaterTest.php:105

mariadb10.3-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #13 (OC\Files\Search\SearchBinaryOperator Object (...), array(1))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
+    0 => '454'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

mysql5.7-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\Wrapper\CacheJailTest::testWithoutNormalizer
Failed asserting that 0 is greater than 0.

/drone/src/tests/lib/Files/Cache/CacheTest.php:567

acceptance-app-comments

• tests/acceptance/features/app-comments.feature:288

Show full log

  Scenario: open a search result for a comment in a folder named like its child folder # /drone/src/tests/acceptance/features/app-comments.feature:288
    Given I am logged in                                                               # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder"                                           # FileListContext::iCreateANewFolderNamed()
    And I open the details view for "Folder"                                           # FileListContext::iOpenTheDetailsViewFor()
    And I open the "Comments" tab in the details view                                  # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I create a new comment with "Hello world" as message                           # CommentsAppContext::iCreateANewCommentWithAsMessage()
    And I see a comment with "Hello world" as message                                  # CommentsAppContext::iSeeACommentWithAsMessage()
    And I enter in the folder named "Folder"                                           # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Folder"                                           # FileListContext::iCreateANewFolderNamed()
    And I open the Files app                                                           # FilesAppContext::iOpenTheFilesApp()
    When I search for "hello"                                                          # SearchContext::iSearchFor()
    And I open the search result 1                                                     # SearchContext::iOpenTheSearchResult()
    Then I see that the details view is open                                           # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I see that the file name shown in the details view is "Folder"                 # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -''
      +'Folder'
    And I see a comment with "Hello world" as message                                  # CommentsAppContext::iSeeACommentWithAsMessage()
    And I see that the file list is currently in "Home"                                # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
    And I see that the file list contains a file named "welcome.txt"                   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I see that the file list contains a file named "Folder"                        # FileListContext::iSeeThatTheFileListContainsAFileNamed()

[MorrisJobke]

Tested and still works fine 👍