Skip to content

[stable18] Fix the user email issue while creating a user #23204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

[stable18] Fix the user email issue while creating a user #23204

merged 1 commit into from
Nov 9, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 5, 2020 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #23182

@sharidasan @backportbot
Fix the user email issue while creating a user
84f4b86 
When the user is created, the provisioning api
was not adding the email address of the user
when provided if the `send email to new user`
is not set.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.10 milestone Oct 5, 2020
@faily-bot
Copy link

faily-bot bot commented Oct 5, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33688: failure

sqlite

Show full log 
There was 1 error:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testRecipientDeleteInShare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:142
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@skjnldsv skjnldsv force-pushed the backport/23182/stable18 branch from 3f73dd5 to 6258606 Compare October 6, 2020 06:53
@skjnldsv skjnldsv force-pushed the backport/23182/stable18 branch from 6258606 to 84f4b86 Compare October 6, 2020 07:01
@MorrisJobke
Copy link
Member

Let's wait for 18.0.11

@rullzer rullzer mentioned this pull request Nov 9, 2020
Merged
2 tasks
@MorrisJobke MorrisJobke mentioned this pull request Nov 9, 2020
Closed
@MorrisJobke MorrisJobke merged commit a4cfac8 into stable18 Nov 9, 2020
@MorrisJobke MorrisJobke deleted the backport/23182/stable18 branch November 9, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@PVince81 PVince81 Awaiting requested review from PVince81

@rullzer rullzer Awaiting requested review from rullzer

@sharidas sharidas Awaiting requested review from sharidas

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: users and groups

Projects

None yet

Milestone

Nextcloud 18.0.11

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @skjnldsv @sharidasan