Skip to content

Fix the user email issue while creating a user #23182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2020
Merged

Fix the user email issue while creating a user #23182

merged 1 commit into from
Oct 5, 2020

Conversation

@sharidas
Copy link
Contributor

@sharidas sharidas commented Oct 5, 2020

When the user is created, the provisioning api
was not adding the email address of the user
when provided if the send email to new user
is not set.

Signed-off-by: Sujith Haridasan sujith.h@gmail.com

@sharidasan
Fix the user email issue while creating a user
62923a5 
When the user is created, the provisioning api
was not adding the email address of the user
when provided if the `send email to new user`
is not set.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
@sharidas sharidas self-assigned this Oct 5, 2020
@sharidas
Copy link
Contributor Author

sharidas commented Oct 5, 2020 •
edited
Loading

Summary

The email address of the user was not updated in the backend when Send email to new user is not checked in the users page.

Description

When user unchecks the Send email to new use and creates a new user with an email address, the email address is not updated. When the Send email to new use is checked this issue is not observed. It would be nice if we don't lose this information.

Issue: #21577

Tests

Updated the existing unit test.

Screenshot of working:

nc_users_page

@sharidas sharidas linked an issue Oct 5, 2020 that may be closed by this pull request
[NC19] Email address is not saved when adding new user #21577
Closed
@sharidas sharidas added the 3. to review Waiting for reviews label Oct 5, 2020
MorrisJobke
MorrisJobke approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise makes sense

@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Oct 5, 2020
@MorrisJobke
Copy link
Member

CI failure is fixed with #23193

@MorrisJobke MorrisJobke merged commit 1ad0631 into nextcloud:master Oct 5, 2020
@welcome
Copy link

welcome bot commented Oct 5, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@MorrisJobke
Copy link
Member

/backport to stable20

@MorrisJobke
Copy link
Member

/backport to stable19

This was referenced Oct 5, 2020
Merged
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Oct 5, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@PVince81 PVince81 Awaiting requested review from PVince81

@rullzer rullzer Awaiting requested review from rullzer

Assignees

@sharidas sharidas

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

[NC19] Email address is not saved when adding new user

4 participants

@sharidas @MorrisJobke @skjnldsv @sharidasan