Closed
Conversation
kesselb
force-pushed
the
enh/hello-phan
branch
from
359d46c to
c3124dc
Compare
kesselb
force-pushed
the
enh/hello-phan
branch
3 times, most recently
from
1435e76 to
e8bd737
Compare
Member
|
Nice ... was about to resurrect the one in drone: a987f80 but this then can go. |
kesselb
force-pushed
the
enh/hello-phan
branch
2 times, most recently
from
737ad18 to
19297ea
Compare
Contributor
Author
|
Changed the level back to critical. Still some warnings to fix. Also SqlInjectionCheckerPlugin is commented. Not sure how to update it. |
kesselb
force-pushed
the
enh/hello-phan
branch
9 times, most recently
from
aabd5bd to
a8cd2cf
Compare
MorrisJobke
reviewed
Jul 9, 2020
MorrisJobke
reviewed
Jul 9, 2020
Member
|
I guess the fixes from here are fine, but the Phan part can go - see #22883 |
Member
Let me rebase this. |
MorrisJobke
force-pushed
the
enh/hello-phan
branch
from
08c6868 to
afb2d8d
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
https://github.com/phan/phan/wiki/Generic-Types#indicating-a-method-creates-an-instance-of-the-passed-in-class-name Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
MorrisJobke
force-pushed
the
enh/hello-phan
branch
from
afb2d8d to
04c1222
Compare
Member
|
Let's extract them step by step in separate PRs. |
This was referenced Sep 16, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Kesselberg mail@danielkesselberg.de