Skip to content

Conversation

@MorrisJobke
Copy link
Member

No brainer by @kesselb from #18680

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@faily-bot
Copy link

faily-bot bot commented Sep 16, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33110: failure

mariadb10.4-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There were 2 failures:

1) Test\Comments\ManagerTest::testGetTreeWithLimitAndOffset
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'5'
+'0'

/drone/src/tests/lib/Comments/ManagerTest.php:212

2) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #228 ('folder', 29, 21)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 16, 2020
@MorrisJobke MorrisJobke merged commit 1bed77c into master Sep 16, 2020
@MorrisJobke MorrisJobke deleted the techdebt/18680/remove-unused-code branch September 16, 2020 18:44
@MorrisJobke MorrisJobke mentioned this pull request Sep 16, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants