Skip to content

Improve registerService logic for ProvisioningApiMiddleware for static code analysis #22891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2020
Merged

Improve registerService logic for ProvisioningApiMiddleware for static code analysis #22891

merged 2 commits into from
Oct 5, 2020

Conversation

@MorrisJobke
Copy link
Member

Extracted from #18680 by @kesselb and refined a bit.

@kesselb @MorrisJobke
Improve registerService logic for ProvisioningApiMiddleware for stati…
46f0410 
…c code analysis

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Sep 16, 2020
@MorrisJobke MorrisJobke mentioned this pull request Sep 16, 2020
Closed
@MorrisJobke
Update baseline
a65b431 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@faily-bot
Copy link

faily-bot bot commented Sep 16, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33115: failure

mysql8.0-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithUserWithNode with data set #1 ('smb::whatever', 'files/test.txt', 'files/test2.txt')
Failed asserting that '64' matches expected 0.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1161

skjnldsv
skjnldsv approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

nickvergessen
nickvergessen approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 22, 2020
@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Oct 5, 2020
@MorrisJobke MorrisJobke merged commit 482b42c into master Oct 5, 2020
@MorrisJobke MorrisJobke deleted the techdebt/18680/improve-ProvisioningApiMiddleware-service-logic branch October 5, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@gary-kim gary-kim gary-kim approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

6 participants

@MorrisJobke @nickvergessen @skjnldsv @gary-kim @kesselb