Adjust acceptance tests to changes in public share page menu#12352
Merged
MorrisJobke merged 1 commit intomasterfrom Nov 8, 2018
Merged
Conversation
The "Download" item in the menu of public share pages is no longer shown in wide (>768px) windows (although the element is in the DOM and shown if resized to a narrow window). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Nov 8, 2018
skjnldsv
approved these changes
Nov 8, 2018
MorrisJobke
deleted the
adjust-acceptance-tests-to-changes-in-public-share-page-menu
branch
danxuliu
restored the
adjust-acceptance-tests-to-changes-in-public-share-page-menu
branch
danxuliu
deleted the
adjust-acceptance-tests-to-changes-in-public-share-page-menu
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Download item in the menu of public share pages is no longer shown in wide (>768px) windows; the element is anyway in the DOM, so the acceptance tests now check that the item is there but hidden.