Better primary visual on public pages

[skjnldsv]

• better visual for the primary button
• hide the download button when the primary is shown

fix #9933
@nextcloud/designers

@juliushaertl should we always display the primary in the menu and only show it when mobile?
I mean, not only the download? 🤔
@nextcloud/designers any thoughts?

[jancborchardt]

(Screenshots please for design changes. ;)

Looking great with the button style – much more call to action! 👍

(But there you can also see how strange the short folder names look left-aligned. ;)

[skjnldsv]

should we always display the primary in the menu and only show it when mobile?
I mean, not only the download? 🤔

What do you think @jancborchardt :)

[jancborchardt]

Sorry, I don't really get the question, could you rephrase? :)

It's ok like it is now. A possible change could be to:

• Show the download icon left of the text in the button
• Then on mobile not simply hide the whole button, but only the text so a circular primary download button is still directly shown.

[skjnldsv]

I mean, always have the primary action outside AND inside the menu.
But only showing the primary when not in mobile view.

Right now we declare the download action twice and hide the menu via css :/

[jancborchardt]

I mean, always have the primary action outside AND inside the menu.

That doesn’t make any sense though. An action should only be shown once.

But only showing the primary when not in mobile view.

I don’t get that? Not showing the 3-dot-menu at all?

I’m confused as to what is wrong with the current design:

• On mobile, you see the 3-dot icon with menu: download, direct link, add to your Nextcloud
• On desktop, the important action of "Download" is directly shown, with the others being still in the menu.

This is also what e.g. Material Design does.

[skjnldsv]

Sorry, I wasn't clear enough 🙈
Currently: the first action is defined as primary and is hidden in mobile view. it will NOT appear in the menu in mobile view. The primary action and the menu are two different things.

I'll suggest we put the primary action back into the menu in mobile mode so we'll have:

1. primary outside and not in menu in desktop view
2. primary not outside BUT in the menu in mobile view.

[MorrisJobke]

@skjnldsv Conflicts :/

[MorrisJobke]

@skjnldsv Conflicts :/

Rebase was quite easy 😄

[MorrisJobke]

I like it 👍

[MorrisJobke]

@juliushaertl should we always display the primary in the menu and only show it when mobile?
I mean, not only the download? 🤔

Let's keep it like that for now in the PR, merge it and discuss about this additional topic in a separate PR/issue.