Replace $verbose with VERBOSITY_VERBOSE for scanFiles method#11968
Merged
Replace $verbose with VERBOSITY_VERBOSE for scanFiles method#11968
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
ChristophWurst
requested changes
Oct 22, 2018
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Please don't mix such changes. Let's just adjust the verbosity output logic in this PR.
| } | ||
| $scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function($path) use ($output) { | ||
| $scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) { | ||
| $output->writeln("\tFile\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE); |
Member
There was a problem hiding this comment.
please don't change these unrelated commands. It's fine to fix/enhance this in another PR though.
| }); | ||
|
|
||
| $scanner->listen('\OC\Files\Utils\Scanner', 'scanFolder', function ($path) use ($output) { | ||
| $output->writeln("\tFolder\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE); |
| } | ||
|
|
||
| $output->writeln("\nScanning AppData for files"); | ||
| $output->writeln('Scanning AppData for files'); |
| protected function presentStats(OutputInterface $output) { | ||
| // Stop the timer | ||
| $this->execTime += microtime(true); | ||
| $output->writeln(""); |
ChristophWurst
requested changes
Oct 22, 2018
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Please don't change the command logic (post increment, output formatting) in this PR 😉
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Member
|
Let's close this one in favor of #11831 |
Member
I just realized that it is for a different command. |
MorrisJobke
approved these changes
Nov 5, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works 👍 Code looks good
Contributor
Author
ChristophWurst
approved these changes
Nov 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #11831
This pr replace
if ($verbose)withOutputInterface::VERBOSITY_VERBOSE