Replace $verbose with VERBOSITY_VERBOSE#11831
Merged
MorrisJobke merged 2 commits intomasterfrom Nov 6, 2018
Merged
Conversation
Contributor
Author
|
I'm a bit unsure about this one server/apps/files/lib/Command/Scan.php Lines 206 to 209 in 0fca815 suppress output looks wrong to me but it was there before. |
Member
|
Nice! Didn't know about this flag. Will definitely use this in future commands 🚀 |
Member
Maybe @icewind1991 can give some input on this. Ref ce2dba0. |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
feature/noid/drop-verbose-scan
branch
from
06b2f1b to
1177ad7
Compare
kesselb
commented
Oct 22, 2018
| } | ||
|
|
||
| $scanner->listen('\OC\Files\Utils\Scanner', 'scanFile', function ($path) use ($output) { | ||
| $output->writeln("\tFile\t<info>$path</info>", OutputInterface::VERBOSITY_VERBOSE); |
Contributor
Author
There was a problem hiding this comment.
@ChristophWurst may i revert \t like you suggested in #11968?
ChristophWurst
approved these changes
Nov 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--verboseand--quietworks out of the box for commands. When you are fine with the default behaviour there is no need to redefine these options within an command.https://github.com/nextcloud/3rdparty/blob/f48c7e29b8001dff95ac00c16338becef1f175dd/symfony/console/Application.php#L865-L868
This pr replace
if ($verbose)withOutputInterface::VERBOSITY_VERBOSE