test(cypress): Adapt selectors to Collabora 24.04 #3634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
tests/cypress-24.04
branch
from
17ff180 to
059a668
Compare
pedropintosilva
previously requested changes
Apr 29, 2024
juliusknorr
force-pushed
the
tests/cypress-24.04
branch
from
059a668 to
c563248
Compare
Passing run #842 ↗︎
Details:
Review all test suite changes for PR #3634 ↗︎ |
|||||||||||||||
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net> test(cypress): Wait for menu to be visible (try) Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…ppears if loading is not fully ready Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
tests/cypress-24.04
branch
from
02cec46 to
99b330b
Compare
juliusknorr
commented
Apr 30, 2024
| cy.waitForPostMessage('App_LoadingStatus', { Status: 'Document_Loaded' }) | ||
|
|
||
| // Share action | ||
| cy.wait(2000) |
Member
Author
There was a problem hiding this comment.
It looks like there is some UI reset once the document renders, but I cannot figure out a proper way to assert that it is actually ready. Would go with the wait for now to move on.
Cypress run recording for reference:
open.spec.failure.mp4
FYI @pedropintosilva Nothing critical i think, though wondering why the UI is reset there
3 tasks
elzody
approved these changes
Apr 30, 2024
Member
Author
|
/backport to stable29 |
Member
Author
|
/backport to stable28 |
Member
Author
|
/backport to stable27 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get main branch back to green with Collabora 24.04 that was recently released and the docker image used by CI was updated