Skip to content

fix(browser): Emit proper UI_PickLink post message #8926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eszkadev merged 1 commit into from
Apr 29, 2024
Merged

fix(browser): Emit proper UI_PickLink post message #8926

eszkadev merged 1 commit into from
Apr 29, 2024

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Apr 29, 2024 •
edited
Loading

Signed-off-by: Julius Härtl jus@bitgrid.net
Change-Id: I635780723b98887e6c35a397940cc2517a6a9025

Summary

Fixes a regression in 24.04 where the link picker button emitted a post message UI UI_PickLink instead of the documented and previously used UI_PickLink

Checklist

  • Code is properly formatted
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr
fix(browser): Emit proper UI_PickLink post message
fce5512 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Change-Id: I635780723b98887e6c35a397940cc2517a6a9025
@juliusknorr juliusknorr added bug Something isn't working regression Something that was working in the past, but not now labels Apr 29, 2024
@juliusknorr juliusknorr mentioned this pull request Apr 29, 2024
Merged
2 tasks
hfiguiere
hfiguiere approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@hfiguiere hfiguiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eszkadev eszkadev enabled auto-merge (rebase) April 29, 2024 16:45
@eszkadev eszkadev merged commit b0b73d2 into master Apr 29, 2024
@eszkadev eszkadev deleted the private/juliushaertl/fix-linkpicker branch April 29, 2024 17:13
@pedropintosilva
Copy link
Contributor

pedropintosilva commented Apr 30, 2024

Context:

  • (for release notes) This fixes Smart Picker not working in 24.04
  • Regression c402ecd Introduce docdispatcher.js (I don't think we will ever backport this to 23.05 but nevertheless let me reiterate: we shouldn't backport c402ecd)

@pedropintosilva pedropintosilva added this to the 24.04.2 milestone Apr 30, 2024
@juliusknorr juliusknorr mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hfiguiere hfiguiere hfiguiere approved these changes

@eszkadev eszkadev eszkadev approved these changes

@gokaysatir gokaysatir Awaiting requested review from gokaysatir

@pedropintosilva pedropintosilva Awaiting requested review from pedropintosilva

Assignees

No one assigned

Labels

24.04 bug Something isn't working regression Something that was working in the past, but not now

Projects

Collabora Online
Archived in project

Milestone

24.04.2

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @pedropintosilva @hfiguiere @eszkadev