Redesign guest name picker and fix opening it for shared folders #3606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
added
bug
elzody
force-pushed
the
fix/guest-username
branch
3 times, most recently
from
b16f9c5 to
b44cb56
Compare
szaimen
approved these changes
Apr 25, 2024
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Screenshot looks good from design perspective :)
juliusknorr
reviewed
Apr 26, 2024
elzody
force-pushed
the
fix/guest-username
branch
from
f6ec7bd to
50e37e3
Compare
elzody
force-pushed
the
fix/guest-username
branch
from
b94c0f5 to
997751a
Compare
juliusknorr
changed the title
juliusknorr
force-pushed
the
fix/guest-username
branch
from
997751a to
b5b7e58
Compare
Member
|
Rebased on top of #3634 |
Member
|
Seems I broke it when rebasing, but should be a quick fix now |
juliusknorr
approved these changes
Apr 30, 2024
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> Signed-off-by: Julius Härtl <jus@bitgrid.net>
elzody
force-pushed
the
fix/guest-username
branch
from
e86bf5c to
63aece8
Compare
Contributor
Author
|
/backport to stable29 |
Contributor
Author
|
/backport to stable28 |
Contributor
Author
|
/backport to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This pull request uses
Office.vueto ask for guest username, which solves the problem of a guest not being asked for a username when accessing a public share located within a shared folder (instead of a direct share link to a file).🖼️ Screenshots
Guest username modal
☑️ Checklist