Ignore roots of groupfolders from autotagging #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
approved these changes
Sep 11, 2019
nickvergessen
commented
Sep 11, 2019
| return $folder === 'files'; | ||
| } else { | ||
| list($folder) = explode('/', $file, 2); | ||
| [$folder, $subPath] = explode('/', $file, 2); |
There was a problem hiding this comment.
There might not be a slash, so this needs more fixing
There was a problem hiding this comment.
Pushed a commit to return early so we don't try to explode the file path if if just contains the base __groupfolders path
juliusknorr
approved these changes
Nov 15, 2019
|
/backport to stable17 |
|
/backport to stable16 |
|
What happened here, the PR is against stable16? :P |
|
Ah right, then I guess it needs some forward-porting. 🙈 |
nickvergessen
force-pushed
the
testing-groupfolder-issues
branch
from
85605b0 to
36365b5
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
testing-groupfolder-issues
branch
from
36365b5 to
6e1c112
Compare
|
Rebased onto latest master. It actually was master based, that's why the unit tests against stable16 failed :D |
|
Failing tests are due to #85 So lets just merge this now |
|
backport to stable17 in #88 |
|
backport to stable16 in #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com