Skip to content

Conversation

@nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling coding@schilljs.com

Signed-off-by: Joas Schilling <coding@schilljs.com>
@blizzz blizzz force-pushed the update-master-php-testing-versions branch from 2f640b1 to 024b7b4 Compare December 17, 2019 11:57
Signed-off-by: Joas Schilling <coding@schilljs.com>
@blizzz blizzz force-pushed the update-master-php-testing-versions branch from 024b7b4 to 578fb2a Compare December 17, 2019 12:03
@blizzz
Copy link
Member

blizzz commented Dec 17, 2019

Failing test is because of #81

thus fixed failing test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz requested a review from juliusknorr December 17, 2019 20:59
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member

blizzz commented Dec 17, 2019

aaand green CI again :)

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@juliusknorr juliusknorr merged commit 005f805 into master Dec 18, 2019
@juliusknorr juliusknorr deleted the update-master-php-testing-versions branch December 18, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants