Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 22, 2019

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
* @param string $file
*/
public function checkOperations(IStorage $storage, $fileId, $file) {
$this->checkManager->setFileInfo($storage, $file);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen Not sure if using the regular file events causes issues here or if we should keep the CacheUpdateEvent/CacheInsertEvent. I guess there were issues with object storage using the storage wrapper according to #71 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah and also files:scan I think. I'd prefer to leave this untouched as much as possible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blizzz I guess we need to move the automated tagging to an IComplexOperation then as well, or do we have a way to limit the available events for an ISpecificOperation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl yes, automatted tagging must be an IComplexOperation because the tags are required to be set asap due to integration with .e.g files_accesscontrol

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
and fix variable name

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz requested a review from nickvergessen November 19, 2019 10:00
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz merged commit 1c061c9 into master Dec 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/workflow branch December 17, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants