- 
                Notifications
    You must be signed in to change notification settings 
- Fork 25
Migrate to new workflow engine #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
| * @param string $file | ||
| */ | ||
| public function checkOperations(IStorage $storage, $fileId, $file) { | ||
| $this->checkManager->setFileInfo($storage, $file); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickvergessen Not sure if using the regular file events causes issues here or if we should keep the CacheUpdateEvent/CacheInsertEvent. I guess there were issues with object storage using the storage wrapper according to #71 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah and also files:scan I think. I'd prefer to leave this untouched as much as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blizzz I guess we need to move the automated tagging to an IComplexOperation then as well, or do we have a way to limit the available events for an ISpecificOperation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliushaertl yes, automatted tagging must be an IComplexOperation because the tags are required to be set asap due to integration with .e.g files_accesscontrol
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
and fix variable name Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
For nextcloud/server#12790
Requires nextcloud-libraries/nextcloud-vue#671