Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve localId via webdav #651

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Retrieve localId via webdav #651

merged 6 commits into from
Jan 19, 2023

Conversation

tobiasKaminsky
Copy link
Member

Needed for nextcloud/android#8643
Signed-off-by: tobiasKaminsky tobias@kaminsky.me

AndyScherzinger
AndyScherzinger previously approved these changes Jul 2, 2021
AndyScherzinger
AndyScherzinger previously approved these changes Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@github-actions github-actions bot deleted a comment from nextcloud-android-bot Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AndyScherzinger
AndyScherzinger previously approved these changes Dec 2, 2022
AlvaroBrey
AlvaroBrey previously approved these changes Dec 2, 2022
@tobiasKaminsky
Copy link
Member Author

@AlvaroBrey

java.lang.AssertionError: expected: java.lang.Long<69> but was: java.lang.String<69>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:120)
at org.junit.Assert.assertEquals(Assert.java:146)
at com.nextcloud.android.lib.resources.search.UnifiedSearchRemoteOperationIT.filesSearch(UnifiedSearchRemoteOperationIT.kt:78)

Attributes is Map<String, String>.
Thus I dare not to touch it.

I now fixed the test, by converting long to String.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #651 (e96ba95) into master (bac776f) will increase coverage by 0.48%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   48.87%   49.35%   +0.48%     
==========================================
  Files         179      179              
  Lines        6726     6739      +13     
  Branches      894      895       +1     
==========================================
+ Hits         3287     3326      +39     
+ Misses       2972     2945      -27     
- Partials      467      468       +1     
Impacted Files Coverage Δ
.../java/com/nextcloud/common/NextcloudUriDelegate.kt 83.33% <ø> (ø)
...om/owncloud/android/lib/common/OwnCloudClient.java 42.85% <ø> (ø)
...urces/files/RestoreFileVersionRemoteOperation.java 0.00% <0.00%> (ø)
...oid/lib/resources/trashbin/model/TrashbinFile.java 0.00% <0.00%> (ø)
...urces/activities/GetActivitiesRemoteOperation.java 35.89% <11.11%> (ø)
...android/lib/resources/files/model/FileVersion.java 33.33% <33.33%> (-2.16%) ⬇️
...id/lib/resources/e2ee/LockFileRemoteOperation.java 63.88% <50.00%> (ø)
...sources/files/ReadFileVersionsRemoteOperation.java 58.97% <55.55%> (ø)
.../android/lib/resources/files/model/RemoteFile.java 45.80% <60.00%> (+0.77%) ⬆️
...ncloud/android/lib/common/network/WebdavEntry.java 79.68% <85.71%> (+1.59%) ⬆️
... and 17 more

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Dec 13, 2022
@AlvaroBrey
Copy link
Member

/rebase

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Dec 16, 2022
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Jan 17, 2023
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@tobiasKaminsky tobiasKaminsky merged commit c4bf73d into master Jan 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the localId branch January 19, 2023 08:10
@AlvaroBrey
Copy link
Member

yay! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants