Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FileVersion: remove duplicate getters #1079

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

AlvaroBrey
Copy link
Member

These getters are generated by Lombok; so it's failing to compile. Test before/after with
gw clean :library:compileDebugJavaWithJavac --no-build-cache

Introduced by #651, not sure how we missed it there

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

@tobiasKaminsky
Copy link
Member

As we want to remove lombok, I think it is better to replace this, with either data class, or with plain Java right now.
Especial this 0 for getFileLength() would otherwise be lost.

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

AlvaroBrey and others added 2 commits March 10, 2023 15:03
These getters are generated by Lombok; so it's failing to compile. Test before/after with
gw clean :library:compileDebugJavaWithJavac --no-build-cache

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AlvaroBrey AlvaroBrey force-pushed the fix/fileversion-duplicate-getter branch from 84d07c8 to 2f37d7d Compare March 10, 2023 14:03
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 140

@AlvaroBrey AlvaroBrey merged commit f5d6344 into master Mar 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/fileversion-duplicate-getter branch March 10, 2023 14:31
@AlvaroBrey AlvaroBrey added this to the NC Android Lib 2.15.0 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants