-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use localID from webdav #8643
Use localID from webdav #8643
Conversation
stable-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1642-Unit-stable-06-24 |
master-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1642-Unit-master-06-25 |
yep sounds like the better approach 👍 |
173e7a0
to
21af2e9
Compare
master-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1645-Unit-master-10-14 |
stable-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1645-Unit-stable-10-14 |
master-Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
stable-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1689-Unit-stable-09-27 |
master-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/1689-Unit-master-09-28 |
CodacyLint
SpotBugs (new)
SpotBugs (master)
Android-library is not set to master branch in build.gradle |
a77ddf1
to
255e0cf
Compare
app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt
Outdated
Show resolved
Hide resolved
app/schemas/com.nextcloud.client.database.NextcloudDatabase/66.json
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/client/database/NextcloudDatabase.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/owncloud/android/datamodel/FileDataStorageManagerIT.java
Outdated
Show resolved
Hide resolved
b104e3d
to
5d25069
Compare
/rebase |
167b00d
to
e15f674
Compare
a01b07f
to
25b6a52
Compare
hi, |
25b6a52
to
c1655d8
Compare
bc03f5b
to
95f0194
Compare
/rebase |
116a532
to
bf76ef3
Compare
6de62d4
to
3eb4cc6
Compare
/rebase |
|
08077bd
to
944a5b7
Compare
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com> Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
…entIT Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8643 +/- ##
============================================
- Coverage 31.58% 31.40% -0.18%
+ Complexity 3400 3383 -17
============================================
Files 566 566
Lines 41601 41613 +12
Branches 5628 5629 +1
============================================
- Hits 13138 13070 -68
- Misses 26508 26593 +85
+ Partials 1955 1950 -5
|
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Library merged, so let us merge this asap. |
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/7442-IT-master-09-45 |
blue-Light-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8643-Screenshot-blue-Light-09-51 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/8643.apk |
🎉🎉🎉 |
Needs nextcloud/android-library#651
After:
@juliushaertl
~~we need to
EDIT: using localId via webdav is the solution!
E.g. my instance has 14 chars for unique id @juliushaertl
To handle this properly we need uniqe id exposed via registered capability, if this is ok for you.Fixes #9826
Fixes #10261