Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 29, 2025

☑️ Resolves

It is a huge PR 🙈
But this is also a huge project!

So this basically migrates from old ESLint v8 to the currently support ESLint v9.
This means we now use the new flat configs and have to use the new nextcloud eslint config.
For review I recommend to either just scroll through the changes to see if there is something weird,
or to do it on a per commit base, as I tried to split every manual change.

  • First commit is just the update of the config + dependencies (infrastructure changes).
  • Second commit is the largest and basically npm run lint:fix - which contains some unwanted or not that nice changes
  • For those are the next commits:
    • Fixing license comments that are not separated from imports and thus used as the import doc block
    • Fixing empty doc blocks for functions
    • Sub-optimal indention - yes its valid but there are better ways with less git diff in the PR so applied them
  • And then there are some commits fixing things ESLint cannot autofix. Please refer to the commit messages why they are needed.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@susnux susnux added the 2. developing Work in progress label Jul 29, 2025
@susnux susnux force-pushed the chore/eslint-v9 branch 6 times, most recently from f588b33 to 7459393 Compare July 30, 2025 19:26
@susnux susnux added dependencies Pull requests that update a dependency file refactor ♻️ Pull request that is neither a fix nor a feature labels Jul 30, 2025
@susnux susnux added this to the 9.0.0 milestone Jul 30, 2025
@ShGKme

This comment was marked as resolved.

@susnux

This comment was marked as outdated.

@susnux susnux force-pushed the chore/eslint-v9 branch 2 times, most recently from f8d3378 to 19230b9 Compare August 1, 2025 00:03
@susnux

This comment was marked as resolved.

@susnux susnux force-pushed the chore/eslint-v9 branch 2 times, most recently from 925f9ab to f41af4a Compare August 1, 2025 16:51
@susnux susnux marked this pull request as ready for review August 1, 2025 17:04
@ShGKme

This comment was marked as resolved.

msgid "Write a message …"
msgid "Write a message …"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes necessary?

  • It is a new translation string - requires updating all translations
  • Does Transifex check that every translation also uses non-breaking space?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Transifex check that every translation also uses non-breaking space?

Not sure if enforced on their side, but I know that this was discussed with the translators to always use nonbreaking space there if possible.

It is a new translation string - requires updating all translations

Yes but in the meantime - as you can see - its already fixed here so its stays translated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but in the meantime - as you can see - its already fixed here so its stays translated.

Does it update values in Transifex, if we change translations in the source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean in the translations? No.
But it helps with keeping translations until the translators had time to adjust them - as otherwise all of those would be lost until they are re-translated just because of whitespace change

@susnux susnux force-pushed the chore/eslint-v9 branch 2 times, most recently from a7aef64 to b25ff52 Compare August 1, 2025 21:21
@susnux susnux requested a review from ShGKme August 1, 2025 21:21
@susnux
Copy link
Contributor Author

susnux commented Aug 1, 2025

Fixed the commits:

  • f8fbc1d (remove default and adjust the then failing test case)
  • 5efb9ed (correct indention of the colors to make the translators comments work)

@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 6, 2025
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Aug 22, 2025

  • Rebased and resolved conflicts
  • Use new eslint-config release where the only change is that we could drop some parts of our custom config here

susnux added 9 commits August 22, 2025 18:05
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/eslint-v9 branch 2 times, most recently from 155914d to 7d12307 Compare August 22, 2025 16:17
susnux added 8 commits August 23, 2025 15:13
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Prevent us from waiting on translators just for whitespace changes.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 76a5d88 into main Aug 23, 2025
25 checks passed
@susnux susnux deleted the chore/eslint-v9 branch August 23, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews dependencies Pull requests that update a dependency file refactor ♻️ Pull request that is neither a fix nor a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants