-
Notifications
You must be signed in to change notification settings - Fork 95
chore: migrate to ESLint v9 #7233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f588b33 to
7459393
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
f8d3378 to
19230b9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
925f9ab to
f41af4a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
| msgid "Write a message …" | ||
| msgid "Write a message …" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes necessary?
- It is a new translation string - requires updating all translations
- Does Transifex check that every translation also uses non-breaking space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Transifex check that every translation also uses non-breaking space?
Not sure if enforced on their side, but I know that this was discussed with the translators to always use nonbreaking space there if possible.
It is a new translation string - requires updating all translations
Yes but in the meantime - as you can see - its already fixed here so its stays translated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but in the meantime - as you can see - its already fixed here so its stays translated.
Does it update values in Transifex, if we change translations in the source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean in the translations? No.
But it helps with keeping translations until the translators had time to adjust them - as otherwise all of those would be lost until they are re-translated just because of whitespace change
a7aef64 to
b25ff52
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
323f097 to
8408430
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8408430 to
78d1889
Compare
|
78d1889 to
3b57c92
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
155914d to
7d12307
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
See also https://eslint.vuejs.org/rules/prefer-prop-type-boolean-first Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Prevent us from waiting on translators just for whitespace changes. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
7d12307 to
263f831
Compare
☑️ Resolves
It is a huge PR 🙈
But this is also a huge project!
So this basically migrates from old ESLint v8 to the currently support ESLint v9.
This means we now use the new flat configs and have to use the new nextcloud eslint config.
For review I recommend to either just scroll through the changes to see if there is something weird,
or to do it on a per commit base, as I tried to split every manual change.
npm run lint:fix- which contains some unwanted or not that nice changes🏁 Checklist
stable8for maintained Vue 2 version or not applicable