[stable8] chore: migrate to ESLint 9 and @nextcloud/eslint-config 9 #7418

ShGKme · 2025-08-31T13:01:33Z

☑️ Resolves

Fix dramastic difference between main and stable8 branches, making backporting complicated
Fix issues with TS support and import eslint plugin
Manual backport of chore: migrate to ESLint v9 #7233
See by commit:
- They mostly apply a single change described in the message
- Almost every commit has green test/eslint/build

🏁 Checklist

⛑️ Tests are included or are not applicable
📘 Component documentation has been extended, updated or is not applicable
2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

ShGKme · 2025-08-31T16:33:09Z

susnux · 2025-08-31T17:19:42Z

Looks like a massive amount of commits 👀
Weird when looking through git history - maybe squash them into auto fixable and rest by logic.

ShGKme · 2025-08-31T17:39:36Z

Looks like a massive amount of commits 👀

To make it easier to review, with a clear understanding of what was the source of what change and why.

A massive amount of commits for a massive amount of changes.

Weird when looking through git history

Why is it a problem?

ShGKme · 2025-09-01T08:32:25Z

I can squash some similar auto-fix commits (that fix related things in the same place as I already did).

But I don't want to squash everything:

Very inconvenient for review — you have just a massive change (that isn't even properly loading in GitHub) of different changes mixed
Hard to see what rule was the source of what change. It is especially useful when the change is weird.
For manual change - also good to see what exactly the change is fixing

E.g., in the original PR the source of some changes is still unclear for me.

ShGKme · 2025-09-01T08:35:44Z

Rebased onto stable8, resolved conflicts in NcCheckboxContent, no actual changes.

Antreesy · 2025-09-01T08:52:37Z

One review please

Antreesy

Looks good

susnux · 2025-09-01T10:48:17Z

build/format-changelog.mjs

 const formatted = content.replaceAll(
 	/by @([^ ]+) in ((https:\/\/github.com\/)nextcloud-libraries\/nextcloud-vue\/pull\/(\d+))/g,
-	'[\#$4]($2) \([$1]($3$1)\)'
+	'[#$4]($2) ([$1]($3$1))',


Diverged here from main as it should include the escaping backslash:

Suggested change

'[#$4]($2) ([$1]($3$1))',

'[\\#$4]($2) \$[$1]($3$1)\$',

I don't understand, why we need a slash here.
But I'll add it to have the same as on the main branch.

susnux · 2025-09-01T10:50:17Z

cypress/visual/NcPasswordField/NcPasswordField.story.vue

 <script setup>
 import NcPasswordField from '../../../src/components/NcPasswordField/NcPasswordField.vue'

+/* eslint-disable vue/require-prop-comment */


can be removed see below

susnux · 2025-09-01T10:50:58Z

eslint.config.mjs

+	// Disable required property documentation for test components
+	{
+		name: '@nextcloud/vue/test-override',
+		files: ['tests/**/*.vue'],


For this branch it needs to be:

Suggested change

files: ['tests/**/*.vue'],

files: [

'cypress/**/*.vue',

'tests/**/*.vue',

],

susnux · 2025-09-01T10:53:01Z

eslint.config.mjs

+		name: '@nextcloud/vue/tests-jest',
+		files: ['tests/**/*.{js,ts}', '**/*.spec.{js,ts}', '**/*.test.{js,ts}'],
+		languageOptions: {
+			globals: {
+				describe: 'readonly',
+				it: 'readonly',
+				test: 'readonly',
+				expect: 'readonly',
+				beforeEach: 'readonly',
+				afterEach: 'readonly',
+				beforeAll: 'readonly',
+				afterAll: 'readonly',
+				jest: 'readonly',
+			},
+		},


Could also make explicit instead with import { ... } from '@jest/globals'
Which we already do in a bunch of test files for better compatibility with vitest (backports work better as in the diff only the import module name changed)

Could also make explicit instead with import { ... } from '@jest/globals'

Yes, but I didn't want to overload already large PR. This is not about ESLint migration itself and can be done in a follow-up.

At this moment this is configuration problem in the first place.

susnux · 2025-09-01T10:53:46Z

src/components/NcActionButton/NcActionButton.vue

+			:class="[{
 				'action-button--active': isChecked,
 				focusable: isFocusable,
 			}]"


Suggested change

:class="[{

'action-button--active': isChecked,

focusable: isFocusable,

}]"

:class="{

'action-button--active': isChecked,

focusable: isFocusable,

}"

Same in some other places, fixing all of them

susnux · 2025-09-01T11:06:04Z

Why is it a problem?

Its hard to see different changes, you have to scroll more than 60 commits in the history log to get to the next changes.

A massive amount of commits for a massive amount of changes.

Yes but very related changes: "Migrate to ESLint 9 and Nextcloud ESLint config v9" 😉
For review it might make sense (as this is cosmetic only - I for example only review on the full changes as I only need to check if behavior is changed and or doc strings make sense).

Nevertheless changes look good, some few comments.

ShGKme · 2025-09-01T11:26:50Z

Added fixups according to the comments, except for import from jest globals. Will do it in a follow up as an a bit unrelated and a large change.

susnux

Looks good but the lock file is a bit large, how did you upgrade? Normally I got like 1/4 of the lockfile lines removed when doing the upgrade to ESLint v9 - even on Vue 2.

DorraJaouad · 2025-09-01T12:53:57Z

src/components/NcAppSidebar/NcAppSidebar.vue

+				logger.warn('[NcAppSidebar] It looks like you want to use NcAppSidebar with the built-in toggle button. '
+					+ 'This feature is only available when NcAppSidebar is used in NcContent.')


Isn't this a useless concat?

I think its done to make the line shorter^^

It can be replaced with

logger.warn('[NcAppSidebar] It looks like you want to use NcAppSidebar with the built-in toggle button. This feature is only available when NcAppSidebar is used in NcContent.')

But then it is a very long line.

So, I'd say - no. It allows making it multi-line in the code.

If its just visually in the editor then you also could just configure your IDE to break lines after X characters, saving one string concat instruction.
But both is fine for me here :)

Anyway, it is not a "useless concat" from the new ESLint rule's perspective 👀

susnux · 2025-09-01T15:03:24Z

I think rebase and squash fixups (DCO) than this should be ready to 🏃

``` npm un eslint vue-eslint-parser @nextcloud/eslint-config eslint-plugin-cypress npm i -D eslint@9 @nextcloud/eslint-config@next ``` Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

ShGKme · 2025-09-01T16:48:55Z

how did you upgrade?

I put the command in the commit description to make it clear and reproduceable :P

npm un eslint vue-eslint-parser @nextcloud/eslint-config eslint-plugin-cypress
npm i -D eslint@9 @nextcloud/eslint-config@next

I double-checked and I haven't found any problems in dependencies bump.

ShGKme · 2025-09-01T16:50:32Z

Rabased onto stable8
Squashed fixup! commits
Squashed some related and small commits decreasing the amount from 69 to 56. I hope this is a bit less scary now :)

No actual more changes.

ShGKme · 2025-09-01T16:53:07Z

Its hard to see different changes, you have to scroll more than 60 commits in the history log to get to the next changes.

For me the review simplicity, rebasing and backporting seems to be more important. (To be honest, I don't know in which case I rely on the scrolling length in git). Because it's about the time of other developers during review.

We also have tons of dependabot commits (one commit + one merge per dependency), many small l10n updates (sometimes several times per day).

ShGKme · 2025-09-01T16:53:39Z

Yes but very related changes: "Migrate to ESLint 9 and Nextcloud ESLint config v9" 😉

This is too large change to work with it as a single change.

The PR to the main was complicated to review for me (that also why I postponed the review). And I saw no chance to backport it commit by commit also because of the size of the changes.

ShGKme self-assigned this Aug 31, 2025

ShGKme added the 2. developing Work in progress label Aug 31, 2025

ShGKme force-pushed the chore/eslint-9 branch from aedc970 to 847f094 Compare August 31, 2025 16:29

ShGKme changed the title ~~[WIP] [stable8] chore: migrate to ESLint 9 and @nextcloud/eslint-config 9~~ [stable8] chore: migrate to ESLint 9 and @nextcloud/eslint-config 9 Aug 31, 2025

ShGKme requested review from Antreesy and susnux August 31, 2025 16:31

ShGKme marked this pull request as ready for review August 31, 2025 16:31

ShGKme added 3. to review Waiting for reviews technical debt and removed 2. developing Work in progress labels Aug 31, 2025

ShGKme force-pushed the chore/eslint-9 branch from 847f094 to 50450d5 Compare September 1, 2025 08:35

ShGKme requested a review from DorraJaouad September 1, 2025 08:37

Antreesy approved these changes Sep 1, 2025

View reviewed changes

susnux reviewed Sep 1, 2025

View reviewed changes

susnux approved these changes Sep 1, 2025

View reviewed changes

DorraJaouad reviewed Sep 1, 2025

View reviewed changes

chore(dev-deps): bump ESLint and @nextcloud/eslint-config to v9

3f048ea

``` npm un eslint vue-eslint-parser @nextcloud/eslint-config eslint-plugin-cypress npm i -D eslint@9 @nextcloud/eslint-config@next ``` Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

ShGKme added 22 commits September 1, 2025 18:45

wip(lint): enable jsdoc/*

2491662

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): partial auto-fix jsdoc/* - blank line + TS

16ea33c

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): partial fix jsdoc/* - docs

681f42e

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(Linkify): migrate directive to ts

bff5a9a

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix no-useless-concat

0f3797d

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix no-useless-escape

03dbef3

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix */no-use-before-define

662256a

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix no-unused-vars

b1fe734

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix @typescript-eslint/no-this-alias

88f512e

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix @stylistic/max-statements-per-line

ac52739

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(NcAppSidebar): note name prop to be required in v9

f8541f7

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix vue/no-required-prop-with-default

d4fa636

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix vue/prefer-prop-type-boolean-first

8858ddf

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix vue/require-default-prop

4153f05

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix no-undef by defining test and build globals

13a357e

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix no-console

2ab8af7

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): suppress @typescript-eslint/no-unused-expressions

d177cc2

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): auto-fix @stylistic/function-paren-newline

a42c0c6

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): suppress vue/no-boolean-default

10fa6c1

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): fix some vue/require-prop-comment

1d00a13

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): suppress vue/require-prop-comment

48c7f37

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

chore(lint): remove disabling warning-level rules

46e17cb

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>

ShGKme force-pushed the chore/eslint-9 branch from 455398d to 46e17cb Compare September 1, 2025 16:47

ShGKme merged commit c6f04cd into stable8 Sep 1, 2025
19 checks passed

ShGKme deleted the chore/eslint-9 branch September 1, 2025 16:50

susnux mentioned this pull request Sep 11, 2025

chore: prepare release v8.31.0 #7496

Merged

		logger.warn('[NcAppSidebar] It looks like you want to use NcAppSidebar with the built-in toggle button. '
		+ 'This feature is only available when NcAppSidebar is used in NcContent.')

[stable8] chore: migrate to ESLint 9 and @nextcloud/eslint-config 9 #7418

[stable8] chore: migrate to ESLint 9 and @nextcloud/eslint-config 9 #7418

Uh oh!

Conversation

ShGKme commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☑️ Resolves

🏁 Checklist

Uh oh!

ShGKme commented Aug 31, 2025

Uh oh!

susnux commented Aug 31, 2025

Uh oh!

ShGKme commented Aug 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShGKme commented Sep 1, 2025

Uh oh!

ShGKme commented Sep 1, 2025

Uh oh!

Antreesy commented Sep 1, 2025

Uh oh!

Antreesy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

susnux commented Sep 1, 2025

Uh oh!

ShGKme commented Sep 1, 2025

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

susnux commented Sep 1, 2025

Uh oh!

ShGKme commented Sep 1, 2025

Uh oh!

ShGKme commented Sep 1, 2025

Uh oh!

Uh oh!

ShGKme commented Sep 1, 2025

Uh oh!

ShGKme commented Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShGKme commented Aug 31, 2025 •

edited

Loading

ShGKme commented Aug 31, 2025 •

edited

Loading