Skip to content

Commit f8fbc1d

Browse files
committed
refactor: remove default where a prop is required
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 688cb5e commit f8fbc1d

File tree

5 files changed

+2
-6
lines changed

5 files changed

+2
-6
lines changed

src/components/NcActionLink/NcActionLink.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ export default {
133133
*/
134134
href: {
135135
type: String,
136-
default: '#',
137136
required: true,
138137
validator: (value) => {
139138
// href is either an anchor or a valid url starting with a scheme or a relative path

src/components/NcActionRouter/NcActionRouter.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ export default {
7474
*/
7575
to: {
7676
type: [String, Object],
77-
default: '',
7877
required: true,
7978
},
8079
},

src/components/NcAppSidebar/NcAppSidebar.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -800,7 +800,6 @@ export default {
800800
*/
801801
name: {
802802
type: String,
803-
default: '',
804803
required: true,
805804
},
806805

src/components/NcRichContenteditable/NcRichContenteditable.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,11 +332,10 @@ export default {
332332
},
333333
334334
/**
335-
* The content
335+
* The text content
336336
*/
337337
modelValue: {
338338
type: String,
339-
default: '',
340339
required: true,
341340
},
342341

tests/unit/components/NcRichContenteditable/NcRichContenteditable.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Tribute.mockImplementation(() => ({
1616
}))
1717

1818
function mountNcRichContenteditable({ props, attrs }: any = {}) {
19-
let currentValue = props?.modelVvalue
19+
let currentValue = props?.modelVvalue ?? ''
2020

2121
const wrapper = mount(NcRichContenteditable, {
2222
props: {

0 commit comments

Comments
 (0)