Skip to content

Commit 688cb5e

Browse files
committed
refactor: use the logger instead of console where possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 3a888a4 commit 688cb5e

File tree

15 files changed

+34
-26
lines changed

15 files changed

+34
-26
lines changed

src/components/NcAppContent/NcAppContent.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ export default {
429429
* Emitted when the list pane is resized by the user
430430
*/
431431
this.$emit('resizeList', { size: listPaneSize })
432-
console.debug('AppContent pane config', listPaneSize)
432+
logger.debug('[NcAppContent] pane config', { listPaneSize })
433433
},
434434
435435
// $slots is not reactive, we need to update this manually
@@ -442,7 +442,7 @@ export default {
442442
restorePaneConfig() {
443443
const listPaneSize = parseInt(browserStorage.getItem(this.paneConfigID), 10)
444444
if (!isNaN(listPaneSize) && listPaneSize !== this.listPaneSize) {
445-
console.debug('AppContent pane config', listPaneSize)
445+
logger.debug('[NcAppContent] pane config', { listPaneSize })
446446
this.listPaneSize = listPaneSize
447447
return listPaneSize
448448
}

src/components/NcAppSidebar/NcAppSidebar.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -749,6 +749,7 @@ import { t } from '../../l10n.ts'
749749
import { createElementId } from '../../utils/createElementId.ts'
750750
import { getTrapStack } from '../../utils/focusTrap.ts'
751751
import { isSlotPopulated } from '../../utils/isSlotPopulated.ts'
752+
import logger from '../../utils/logger.ts'
752753
import NcActions from '../NcActions/index.js'
753754
import NcAppSidebarHeader from '../NcAppSidebarHeader/index.ts'
754755
import NcButton from '../NcButton/index.ts'
@@ -1225,8 +1226,7 @@ export default {
12251226
checkToggleButtonContainerAvailability() {
12261227
// Toggle button must be rendered, but there is no element to teleport it to
12271228
if (this.open === false && !this.noToggle && !this.ncContentSelector) {
1228-
console.warn('[NcAppSidebar] It looks like you want to use NcAppSidebar with the built-in toggle button. '
1229-
+ 'This feature is only available when NcAppSidebar is used in NcContent.')
1229+
logger.warn('[NcAppSidebar] It looks like you want to use NcAppSidebar with the built-in toggle button. This feature is only available when NcAppSidebar is used in NcContent.')
12301230
}
12311231
},
12321232

src/components/NcAvatar/NcAvatar.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -825,7 +825,7 @@ export default {
825825
setUserHasAvatar(this.user, true)
826826
}
827827
img.onerror = () => {
828-
console.debug('Invalid avatar url', url)
828+
logger.debug('[NcAvatar] Invalid avatar url', { url })
829829
// Avatar is invalid, reset
830830
this.avatarUrlLoaded = null
831831
this.avatarSrcSetLoaded = null

src/components/NcCollectionList/NcCollectionList.vue

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ export default {
140140
loading(true)
141141
searchService(query).then((collections) => {
142142
searchCollections.value = collections
143-
}).catch((e) => {
144-
console.error('Failed to search for collections', e)
143+
}).catch((error) => {
144+
logger.error('Failed to search for collections', { error })
145145
}).finally(() => {
146146
loading(false)
147147
})
@@ -246,7 +246,7 @@ export default {
246246
this.setError(t('Failed to create a project'), e)
247247
})
248248
}).catch((e) => {
249-
console.error('No resource selected', e)
249+
loger.error('[NcCollectionList] No resource selected', e)
250250
})
251251
}
252252
@@ -267,7 +267,7 @@ export default {
267267
},
268268
269269
setError(error, e) {
270-
console.error(error, e)
270+
logger.error(error, { error: e })
271271
this.error = error
272272
setTimeout(() => {
273273
this.error = null
@@ -277,7 +277,7 @@ export default {
277277
renameCollectionFromItem({ collectionId, name }) {
278278
this.renameCollection({ collectionId, name })
279279
.catch((e) => {
280-
console.error(t('Failed to rename the project'), e)
280+
logger.error(t('Failed to rename the project'), { error: e })
281281
this.collectionsError[collectionId] = t('Failed to rename the project')
282282
setTimeout(() => {
283283
this.collectionsError[collectionId] = null

src/components/NcPopover/NcPopover.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,7 @@ import { createFocusTrap } from 'focus-trap'
215215
import { warn } from 'vue'
216216
import NcPopoverTriggerProvider from './NcPopoverTriggerProvider.vue'
217217
import { getTrapStack } from '../../utils/focusTrap.ts'
218+
import logger from '../../utils/logger.ts'
218219
import { isRtl } from '../../utils/rtl.ts'
219220
220221
/**
@@ -522,8 +523,8 @@ export default {
522523
try {
523524
this.$focusTrap?.deactivate(options)
524525
this.$focusTrap = null
525-
} catch (err) {
526-
console.warn(err)
526+
} catch (error) {
527+
logger.warn('[NcPopover] Failed to clear focus trap', { error })
527528
}
528529
},
529530

src/components/NcRelatedResourcesPanel/NcRelatedResourcesPanel.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -243,9 +243,9 @@ export default {
243243
try {
244244
const response = await axios.get(this.url)
245245
this.resources = response.data.ocs?.data
246-
} catch (e) {
247-
this.error = e
248-
console.error(e)
246+
} catch (error) {
247+
this.error = error
248+
logger.error('[NcRelatedResourcesPanel] Failed to fetch resources', { error })
249249
} finally {
250250
this.loading = false
251251
}

src/components/NcRelatedResourcesPanel/NcTeamResources.vue

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ import OpenInNew from 'vue-material-design-icons/OpenInNew.vue'
8282
import NcButton from '../NcButton/NcButton.vue'
8383
import NcIconSvgWrapper from '../NcIconSvgWrapper/NcIconSvgWrapper.vue'
8484
import { t } from '../../l10n.ts'
85+
import logger from '../../utils/logger.ts'
8586
8687
const teamResourceProviders = getCapabilities()?.circles?.teamResourceProviders ?? []
8788
@@ -178,9 +179,9 @@ export default {
178179
const response = await axios.get(generateOcsUrl(`/teams/resources/${this.providerId}/${this.itemId}`))
179180
this.teamResources = response.data.ocs.data.teams
180181
this.teamOpen = [this.teamResources[0]?.teamId]
181-
} catch (e) {
182+
} catch (error) {
182183
this.teamResources = null
183-
console.error(e)
184+
logger.error('[NcTeamResources] Failed to fetch resources', { error })
184185
} finally {
185186
this.loading = false
186187
}

src/components/NcRichContenteditable/NcRichContenteditable.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ import { emojiAddRecent, emojiSearch } from '../../functions/emoji/index.ts'
293293
import { n, t } from '../../l10n.ts'
294294
import richEditor from '../../mixins/richEditor/index.js'
295295
import { createElementId } from '../../utils/createElementId.ts'
296+
import logger from '../../utils/logger.ts'
296297
import { getLinkWithPicker, searchProvider } from '../NcRichText/index.js'
297298
298299
/**
@@ -694,7 +695,7 @@ export default {
694695
}
695696
})
696697
.catch((error) => {
697-
console.debug('Smart picker promise rejected:', error)
698+
logger.debug('[NcRichContenteditable] Smart picker promise rejected:', { error })
698699
const tmpElem = document.getElementById('tmp-smart-picker-result-node')
699700
this.setCursorAfter(tmpElem)
700701
tmpElem.remove()

src/components/NcRichText/NcReferenceList.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export default {
135135
this.loading = false
136136
this.$emit('loaded')
137137
}).catch((error) => {
138-
console.error('Failed to extract references', error)
138+
logger.error('[NcReferenceList] Failed to extract references', { error })
139139
this.loading = false
140140
this.$emit('loaded')
141141
})

src/components/NcRichText/NcReferencePicker/NcRawLinkInput.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ import debounce from 'debounce'
4343
import LinkVariantIcon from 'vue-material-design-icons/LinkVariant.vue'
4444
import NcReferenceWidget from '../NcReferenceWidget.vue'
4545
import { t } from '../../../l10n.ts'
46+
import logger from '../../../utils/logger.ts'
4647
import NcEmptyContent from '../../NcEmptyContent/index.ts'
4748
import NcLoadingIcon from '../../NcLoadingIcon/index.ts'
4849
import NcTextField from '../../NcTextField/index.ts'
@@ -129,7 +130,7 @@ export default {
129130
this.reference = response.data.ocs.data.references[this.inputValue]
130131
})
131132
.catch((error) => {
132-
console.error(error)
133+
logger.error('[NcRawLinkInput] Failed to update reference', { error })
133134
})
134135
.then(() => {
135136
this.loading = false

0 commit comments

Comments
 (0)