fix(useIsDarkTheme): provide default value to silence runtime warnings #7185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable8 |
Antreesy
approved these changes
Jul 20, 2025
ShGKme
approved these changes
Jul 21, 2025
| export function useIsDarkTheme(): DeepReadonly<Ref<boolean>> { | ||
| const isDarkTheme = useInternalIsDarkTheme() | ||
| const enforcedTheme = inject(INJECTION_KEY_THEME) | ||
| const enforcedTheme = inject(INJECTION_KEY_THEME, computed<''>(() => '')) |
Contributor
There was a problem hiding this comment.
Why not undefined, to not create additional computed?
Suggested change
| const enforcedTheme = inject(INJECTION_KEY_THEME, computed<''>(() => '')) | |
| const enforcedTheme = inject(INJECTION_KEY_THEME, undefined) |
Contributor
There was a problem hiding this comment.
Could you tell if it's worth making a new release?
From what I see locally, this one thing is killing performance (when many avatars rendered, 136 in this example):
| before | with , undefined added |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
So far noticed only while testing 9.0.0-rc.4 against this branch.
Maybe a result of #7157
susnux
force-pushed
the
fix/theme-warning
branch
from
6c59210 to
d2acae7
Compare
Otherwise if no `NcThemeProvider` is used a runtime warning is shown in the dev tools console. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/theme-warning
branch
from
d2acae7 to
35829a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Otherwise if no
NcThemeProvideris used a runtime warning is shown in the dev tools console.🏁 Checklist
stable8for maintained Vue 2 version or not applicable