Skip to content

fix(useIsDarkTheme): provide default value to silence runtime warnings #7185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

fix(useIsDarkTheme): provide default value to silence runtime warnings #7185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/composables/useIsDarkTheme/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ import type { ComputedRef, InjectionKey } from 'vue'
*
* @private
*/
export const INJECTION_KEY_THEME: InjectionKey<ComputedRef<'light' | 'dark' | ''>> = Symbol.for('nc:theme:enforced')
export const INJECTION_KEY_THEME: InjectionKey<ComputedRef<'light' | 'dark' | ''> | undefined> = Symbol.for('nc:theme:enforced')
2 changes: 1 addition & 1 deletion src/composables/useIsDarkTheme/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const useInternalIsDarkTheme = createSharedComposable(() => useIsDarkThemeElemen
*/
export function useIsDarkTheme(): DeepReadonly<Ref<boolean>> {
const isDarkTheme = useInternalIsDarkTheme()
const enforcedTheme = inject(INJECTION_KEY_THEME)
const enforcedTheme = inject(INJECTION_KEY_THEME, undefined)

return computed(() => {
if (enforcedTheme?.value) {
Expand Down
Loading