feat(NcThemeProvider): allow to override the current theme for parts of the UI #6764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
susnux
changed the title
Contributor
Author
|
/backport to stable8 |
ShGKme
reviewed
Apr 10, 2025
susnux
force-pushed
the
feat/nc-date-time
branch
from
c4ffa42 to
ef6260a
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
ShGKme
reviewed
Jul 15, 2025
Co-authored-by: Grigorii K. Shartsev <me@shgk.me> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/nc-date-time
branch
from
3fb2c80 to
1dd2dc2
Compare
Antreesy
approved these changes
Jul 15, 2025
| </script> | ||
|
|
||
| <template> | ||
| <div :[`data-theme-${theme}`]="theme"> |
Contributor
There was a problem hiding this comment.
Work, although I'm not fond of having another wrapper.
Contributor
Author
There was a problem hiding this comment.
Would you prefer a directive?
Contributor
There was a problem hiding this comment.
Sorry, missed that. I meant putting everything in another div, although this would feel better as a directive, yes
ShGKme
approved these changes
Jul 15, 2025
Antreesy
reviewed
Jul 19, 2025
| export const useIsDarkTheme = createSharedComposable(() => useIsDarkThemeElement()) | ||
| export function useIsDarkTheme(): DeepReadonly<Ref<boolean>> { | ||
| const isDarkTheme = useInternalIsDarkTheme() | ||
| const enforcedTheme = inject(INJECTION_KEY_THEME) |
Contributor
There was a problem hiding this comment.
Shouldn't there be a default value passed? Console is bloating with warnings:
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Allow to overwrite the theme for some parts of the UI.
Also adjust the dark theme composable to respect this value by using the injected theme.
🏁 Checklist
stable8for maintained Vue 2 version or not applicable