-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcActions): Allow to manually specify the semantic menu type #5336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, and I also thought about this way, but I'm not sure it is a good way to solve the issue.
- It fixes only 1/3 issues with non-direct children.
we can make use of NcActions even when wrapping common groups of actions in components
only applies to a11y issues, we still cannot use it havinginline
andsingle button
features.
- It must be used carefully because it can result in completely incorrect behavior, for example:
- If there is no focusable element, without type
Tooltip
keyboard navigation is very broken. And the opposite - If it says "menu" but there are input elements - menu has invalid a11y. And we should take into account that it can be changed ([NcActions] doesn't fully support changing type during open state #5334)
- If there is no focusable element, without type
At the same time, I don't see any simple full working solution with current implementation.
The only fully working alternative is to always "render" all the slot content, but make all the NcAction*
"renderless" and use them as a config transfer object like NcAppSidebarTab
does. It should require quite a huge implementation change and always have 2-stage rendering.
So I'm fine with it as a simple temporary solution if there are cases where it is required.
As far as I know, in server
, photos
, text
, activity
there are no issues with this limitation. But there could be in mail
, talk
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice documentation for a11y!
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9ca3647
to
a7c4f08
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
a7c4f08
to
8c72eb4
Compare
/backport to next |
☑️ Resolves
So we can make use of
NcActions
even when wrapping common groups of actions in components.🏁 Checklist
next
requested with a Vue 3 upgrade