[NcActions] doesn't fully support changing type during open state #5334
Labels
1. to develop
Accepted and waiting to be taken care of
bug
Something isn't working
feature: actions
Related to the actions components
NcActions
can have a different type: navigation (expanded list), application menu, form dialog.It not only changes attributes for a11y but also keyboard navigation and
focus-trap
integration.But it doesn't work well when it is changed during menu usage.
Example — renaming an address book in Contacts app.
input
. With a form, this popup is no longer a menu but a dialog form. Dialog is supposed to have its own focus trap. But it doesn't, because a focus trap should have been enabled initially inNcPopover
.A solution could be:
focusTrap
setting change support toNcPopover
so we can enablefocusTrap
for existeddialog
NcActions
on close if it was paused before, not matter if was expected.See also: nextcloud/contacts#3812
The text was updated successfully, but these errors were encountered: