Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] feat(NcActions): Allow to manually specify the semantic menu type #5395

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 11, 2024

Backport of #5336

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@backportbot backportbot bot requested review from emoral435, ShGKme and susnux March 11, 2024 12:03
@backportbot backportbot bot added enhancement New feature or request 3. to review Waiting for reviews feature: actions Related to the actions components labels Mar 11, 2024
@susnux susnux force-pushed the backport/5336/next branch from 9a45a4c to fc0ac7e Compare March 11, 2024 12:26
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the backport/5336/next branch from fc0ac7e to feced19 Compare March 11, 2024 13:47
@susnux susnux marked this pull request as ready for review March 20, 2024 01:18
@ShGKme
Copy link
Contributor

ShGKme commented Mar 20, 2024

This doesn't work on next.

findActions only searches for NcAction* components, so rendering is stopped before it checked for forcedType.

		// Check that we have at least one action
		if (actions.length === 0) {
			return
		}

@susnux susnux added this to the 9.0.0 milestone May 17, 2024
@susnux susnux modified the milestones: 9.0.0, 9.0.0-alpha.4 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants