Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laconia#48 - Ignore if callback is falsy #415

Closed
wants to merge 35 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
cecd3bc
laconia#48 - serverless-offline raises warning due to callback usage;…
Nov 21, 2019
f2967c4
laconia#48 - serverless-offline raises warning due to callback usage;…
Nov 21, 2019
61e4562
Bump aws-sdk from 2.574.0 to 2.575.0
dependabot-preview[bot] Nov 20, 2019
bcbaa1e
Bump @types/node from 12.12.9 to 12.12.11
dependabot-preview[bot] Nov 20, 2019
0626381
Bump eslint-config-prettier from 6.6.0 to 6.7.0
dependabot-preview[bot] Nov 20, 2019
eb24c40
Bump lerna from 3.18.4 to 3.18.5
dependabot-preview[bot] Nov 20, 2019
39608e3
Bump coveralls from 3.0.7 to 3.0.8
dependabot-preview[bot] Nov 21, 2019
ff805ac
Bump serverless from 1.57.0 to 1.58.0
dependabot-preview[bot] Nov 21, 2019
f9355a1
Bump dynamodb-local from 0.0.30 to 0.0.31
dependabot-preview[bot] Nov 21, 2019
ce9717e
Bump lerna from 3.18.5 to 3.19.0
dependabot-preview[bot] Nov 21, 2019
78c7b5d
Bump aws-sdk from 2.575.0 to 2.576.0
dependabot-preview[bot] Nov 21, 2019
46f6dc2
Bump pino from 5.13.6 to 5.14.0
dependabot-preview[bot] Nov 22, 2019
21a91e8
Bump aws-sdk from 2.576.0 to 2.577.0
dependabot-preview[bot] Nov 22, 2019
f76e8f5
Bump prettier from 1.18.2 to 1.19.1
dependabot-preview[bot] Nov 21, 2019
30b0dbc
fix lint errors, npm audit fix
geoffdutton Nov 22, 2019
b55ea97
Bump aws-sdk from 2.577.0 to 2.578.0
dependabot-preview[bot] Nov 25, 2019
694115e
Bump @types/node from 12.12.11 to 12.12.12
dependabot-preview[bot] Nov 25, 2019
03af378
Bump eslint from 6.6.0 to 6.7.1
dependabot-preview[bot] Nov 25, 2019
fac1238
Bump npm-package-json-lint from 4.0.2 to 4.2.0
dependabot-preview[bot] Nov 18, 2019
d158dcb
force npm-package-json-lint to ignore node_modules in packages/
geoffdutton Nov 22, 2019
e9f9c7c
Bump aws-sdk from 2.578.0 to 2.579.0
dependabot-preview[bot] Nov 26, 2019
7cac50c
Bump @types/node from 12.12.12 to 12.12.14
dependabot-preview[bot] Nov 26, 2019
05987e7
Bump coveralls from 3.0.8 to 3.0.9
dependabot-preview[bot] Nov 27, 2019
3e5ea09
Bump aws-sdk from 2.579.0 to 2.580.0
dependabot-preview[bot] Nov 27, 2019
3d44c5b
Bump eslint from 6.7.1 to 6.7.2
dependabot-preview[bot] Dec 2, 2019
cfcabba
Bump aws-sdk from 2.580.0 to 2.582.0
dependabot-preview[bot] Dec 3, 2019
278f10b
Bump aws-sdk from 2.582.0 to 2.584.0
dependabot-preview[bot] Dec 4, 2019
ff8c492
Bump serverless-s3-sync from 1.9.1 to 1.9.2
dependabot-preview[bot] Dec 4, 2019
e468799
GH-419 Delete total-order bucket on sls remove
ceilfors Nov 29, 2019
ac64150
GH-419 Create the required apikey parameter automatically
ceilfors Dec 2, 2019
54dea76
GH-419 Update acceptance test runtime from node8 to node10
ceilfors Dec 3, 2019
9464182
#389 - Ease the run of manual acceptance tests; commit: add accountId…
Dec 4, 2019
2400f94
laconia#48 - serverless-offline raises warning due to callback usage;…
Dec 4, 2019
a9303ad
laconia#48 - serverless-offline raises warning due to callback usage;…
Dec 4, 2019
603d810
laconia#48 - serverless-offline raises warning due to callback usage;…
Dec 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH-419 Create the required apikey parameter automatically
The parameter is being created in acceptance.spec.js because CloudFormation does not support SecretString creation, obviously due to security reason.
In our case, as this is not really a secret, it is safe for us to have the plain text secret in our test.

This closes #418
  • Loading branch information
ceilfors authored and Hugo Ribeiro committed Dec 4, 2019
commit ac64150e6d77fad215acefb7a38040012adb1564
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,17 @@ const deleteAllItems = async (tableName, keyName, keyValue) => {
}
};

const storeApiKey = () => {
return new AWS.SSM()
.putParameter({
Name: `/${prefix}/apikey`,
Type: "SecureString",
Value: "supersecretkey",
Overwrite: true
})
.promise();
};

const createOrder = (restaurantId, total) => ({
restaurantId,
customer: {
Expand Down Expand Up @@ -157,6 +168,7 @@ describe("order flow", () => {
);
});

beforeAll(() => storeApiKey());
beforeAll(async () => {
orderUrl = await getOrderUrl();
});
Expand Down