-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laconia#48 - Ignore if callback is falsy #415
Conversation
… commit: use return when callback is falsy
… commit: Create another entrypoint (ie: @laconia/core/async)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hugosenari. Thanks for this PR. I personally feel that it's quite difficult to ask our users to add more boilerplate code to get rid of the warnings.
The solution from @geoffdutton might work more seamlessly for our users if you want to fix this issue. Although bear in mind that it triggered test failures (I can't remember in detail now), which I have documented here. I suspect that it might just test configuration issue.
I know, I have another branch for @geoffdutton solution and found where is the fail point, but it breaks API. Options:
And is not just warnings, annoys me that I need set context.callbackWaitsForEmptyEventLoop to false because we are using callbacks, thats why I suggest that if we don't have callback, we don't use it. And since it will be a common pattern (unless we break api) create built-in boilerplate to do that. 😄 |
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.574.0 to 2.575.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.574.0...v2.575.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.12.9 to 12.12.11. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.6.0 to 6.7.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md) - [Commits](https://github.com/prettier/eslint-config-prettier/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.18.4 to 3.18.5. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.18.5/core/lerna) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [coveralls](https://github.com/nickmerwin/node-coveralls) from 3.0.7 to 3.0.8. - [Release notes](https://github.com/nickmerwin/node-coveralls/releases) - [Commits](https://github.com/nickmerwin/node-coveralls/commits/3.0.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [serverless](https://github.com/serverless/serverless) from 1.57.0 to 1.58.0. - [Release notes](https://github.com/serverless/serverless/releases) - [Changelog](https://github.com/serverless/serverless/blob/master/CHANGELOG.md) - [Commits](serverless/serverless@v1.57.0...v1.58.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [dynamodb-local](https://github.com/doapp-ryanp/dynamodb-local) from 0.0.30 to 0.0.31. - [Release notes](https://github.com/doapp-ryanp/dynamodb-local/releases) - [Commits](https://github.com/doapp-ryanp/dynamodb-local/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [lerna](https://github.com/lerna/lerna/tree/HEAD/core/lerna) from 3.18.5 to 3.19.0. - [Release notes](https://github.com/lerna/lerna/releases) - [Changelog](https://github.com/lerna/lerna/blob/master/core/lerna/CHANGELOG.md) - [Commits](https://github.com/lerna/lerna/commits/v3.19.0/core/lerna) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.575.0 to 2.576.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.575.0...v2.576.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [pino](https://github.com/pinojs/pino) from 5.13.6 to 5.14.0. - [Release notes](https://github.com/pinojs/pino/releases) - [Commits](pinojs/pino@v5.13.6...v5.14.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.576.0 to 2.577.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.576.0...v2.577.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [prettier](https://github.com/prettier/prettier) from 1.18.2 to 1.19.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](prettier/prettier@1.18.2...1.19.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.577.0 to 2.578.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.577.0...v2.578.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.12.11 to 12.12.12. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint](https://github.com/eslint/eslint) from 6.6.0 to 6.7.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v6.6.0...v6.7.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [npm-package-json-lint](https://github.com/tclindner/npm-package-json-lint) from 4.0.2 to 4.2.0. - [Release notes](https://github.com/tclindner/npm-package-json-lint/releases) - [Changelog](https://github.com/tclindner/npm-package-json-lint/blob/master/CHANGELOG.md) - [Commits](tclindner/npm-package-json-lint@v4.0.2...v4.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.578.0 to 2.579.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.578.0...v2.579.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 12.12.12 to 12.12.14. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [coveralls](https://github.com/nickmerwin/node-coveralls) from 3.0.8 to 3.0.9. - [Release notes](https://github.com/nickmerwin/node-coveralls/releases) - [Commits](nickmerwin/node-coveralls@3.0.8...3.0.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.579.0 to 2.580.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.579.0...v2.580.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint](https://github.com/eslint/eslint) from 6.7.1 to 6.7.2. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v6.7.1...v6.7.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.580.0 to 2.582.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.580.0...v2.582.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.582.0 to 2.584.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-js@v2.582.0...v2.584.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [serverless-s3-sync](https://github.com/k1LoW/serverless-s3-sync) from 1.9.1 to 1.9.2. - [Release notes](https://github.com/k1LoW/serverless-s3-sync/releases) - [Commits](k1LoW/serverless-s3-sync@v1.9.1...v1.9.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
The parameter is being created in acceptance.spec.js because CloudFormation does not support SecretString creation, obviously due to security reason. In our case, as this is not really a secret, it is safe for us to have the plain text secret in our test. This closes nearst#418
…ountId to buckets name
… commit: ignore callback if user set LACONIA_NO_CALLBACK = "true"
… commit: testing laconia without callback
… commit: remove async wrapper
Updates:
|
This will come out in the next release ? |
closing this in favor of: #511 |
Partially solves #48
Changes:
Things to do after that (for other PRs):