Create SSM secret automatically - partially solve #389 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SSM secret is not created automatically.
hugosenari
changed the title
hugosenari
changed the title
ceilfors
approved these changes
Nov 25, 2019
|
Sadly, CloudFormation doesn't support creating a SecureString parameter type. Anyway with this, at least we test that Laconia/Config reads information from SSM. :-) |
ceilfors
added a commit
that referenced
this pull request
Dec 3, 2019
The parameter is being created in acceptance.spec.js because CloudFormation does not support SecretString creation, obviously due to security reason. In our case, as this is not really a secret, it is safe for us to have the plain text secret in our test. This closes #418
ceilfors
reviewed
Dec 4, 2019
There was a problem hiding this comment.
Hey @hugosenari. I have another PR that will close this PR: #432. Let me know what you think!
|
close this in favor of PR: #432 |
hugosenari
pushed a commit
to hugosenari/laconia
that referenced
this pull request
Dec 4, 2019
The parameter is being created in acceptance.spec.js because CloudFormation does not support SecretString creation, obviously due to security reason. In our case, as this is not really a secret, it is safe for us to have the plain text secret in our test. This closes nearst#418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#389 - Ease the run of manual acceptance tests: