Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rosetta tests to CI #3186

Open
MaksymZavershynskyi opened this issue Aug 17, 2020 · 8 comments
Open

Add Rosetta tests to CI #3186

MaksymZavershynskyi opened this issue Aug 17, 2020 · 8 comments
Assignees
@firatNEAR
Labels
A-CI Area: Continuous Integration A-RPC Area: rpc A-testing Area: Unit testing / integration testing T-integrations Team: issues relevant to the integrations team

Comments

@MaksymZavershynskyi
Copy link
Contributor

We need to run Rosetta test suite as part of our CI to be able to know when something gets broken.
@MaksymZavershynskyi MaksymZavershynskyi added A-CI Area: Continuous Integration A-RPC Area: rpc A-testing Area: Unit testing / integration testing labels Aug 17, 2020
@frol
Copy link
Collaborator

frol commented Aug 17, 2020 •
edited
Loading

Plan

  • Configure the test suite:
    a. Run rosetta-cli check:construction (configure rosetta.cfg with some scenarios)
    b. Run rosetta-cli check:data in parallel with rosetta-cli check:construction
  • Add compilation of nearcore with the rosetta_rpc feature flag enabled and include the test suite execution to our CI setup

@bowenwang1996 bowenwang1996 added the T-public-interfaces Team: issues relevant to the public interfaces team label Jun 29, 2021
@bowenwang1996
Copy link
Collaborator

@frol what is the status of this issue?

@frol
Copy link
Collaborator

frol commented Aug 9, 2021

This issue is still relevant, but not urgent.

@stale
Copy link

stale bot commented Nov 7, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Nov 7, 2021
@bowenwang1996
Copy link
Collaborator

@mina86 I think it is probably a good first task for you in terms of Rosetta

@stale stale bot removed the S-stale label Nov 8, 2021
@bowenwang1996 bowenwang1996 assigned mina86 and unassigned frol Nov 8, 2021
mina86 added a commit to Near-One/nayduck that referenced this issue Nov 23, 2021
@mina86
builder: enable rosetta_rpc feature in builds
79cb4d7 
Issue: near/nearcore#3186
@mina86 mina86 mentioned this issue Nov 23, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Nov 24, 2021
@mina86
pytest: add Rosetta RPC imilicit account deletion test (#5441)
bd386b8 
For the time being Rosetta related class is stored in the test file
rather than in a module.  When more tests are added this will possibly
need to be refactored.

Issue: #3186
Issue: #5405
mina86 added a commit to mina86/nearcore that referenced this issue Nov 25, 2021
@mina86
nightly: document --skip-build test flag plus some other minor updates
8e7ecde 
Issue: near#3186
Issue: near#4726
mina86 added a commit to mina86/nearcore that referenced this issue Nov 25, 2021
@mina86
nightly: document --skip-build test flag plus some other minor updates
ac867e5 
Issue: near#3186
Issue: near#4726
@mina86 mina86 mentioned this issue Nov 25, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Nov 25, 2021
@mina86
nightly: document --skip-build test flag plus some other minor updates (
eecb39a 
#5469)

Issue: #3186
Issue: #4726
mina86 added a commit to mina86/nearcore that referenced this issue Dec 2, 2021
@mina86
pytest: close stdout and stderr when local node is cleaned up
296470f 
This fixes the following warning when trying to run tests with
unittest fixture:

    sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mpn/.near/test0/stdout' mode='a' encoding='UTF-8'>
    sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mpn/.near/test0/stderr' mode='a' encoding='UTF-8'>

Issue: near#3186
Issue: near#4618
@mina86 mina86 mentioned this issue Dec 2, 2021
Merged
mina86 added a commit to mina86/nearcore that referenced this issue Dec 2, 2021
@mina86
pytest: kill node process through Popen class and then wait for it
3504217 
This fixes the following warning:

    ../usr/lib/python3.9/subprocess.py:1052: ResourceWarning: subprocess 91224 is still running
      _warn("subprocess %s is still running" % self.pid,

which is caused by LocalNode not waiting for the thread to terminate
after it’s killed.

Issue: near#3186
Issue: near#4618
This was referenced Dec 2, 2021
Merged
Merged
near-bulldozer bot pushed a commit that referenced this issue Dec 2, 2021
@mina86
pytest: close stdout and stderr when local node is cleaned up (#5576)
7d80bf0 
This fixes the following warning when trying to run tests with
unittest fixture:

    sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mpn/.near/test0/stdout' mode='a' encoding='UTF-8'>
    sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mpn/.near/test0/stderr' mode='a' encoding='UTF-8'>

Issue: #3186
Issue: #4618
near-bulldozer bot pushed a commit that referenced this issue Dec 2, 2021
@mina86
pytest: add /block Rosetta RPC tests (#5582)
8ca4deb 
Refactor Rosetta RPC test and most importantly add a test for /block
and /block/transaction endpoints.

Issue: #3186
Issue: #5173
mina86 added a commit to mina86/nearcore that referenced this issue Dec 6, 2021
@mina86
buildkite: add Rosetta RPC tests to CI nightly test run
0d90f4a 
Issue: near#3186
@mina86 mina86 mentioned this issue Dec 6, 2021
Merged
mina86 added a commit to mina86/nearcore that referenced this issue Dec 6, 2021
@mina86
pytest: rosetta: add tests for looking at transactions
f56b49c 
Issue: near#5173
Issue: near#3186
@mina86 mina86 mentioned this issue Dec 6, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Dec 7, 2021
@mina86
buildkite: add Rosetta RPC tests to CI nightly test run (#5679)
264568b 
Issue: #3186
@mina86
Copy link
Contributor

mina86 commented Dec 7, 2021

I’m still going to be adding pytest tests but I think this can be closed.

@mina86 mina86 closed this as completed Dec 7, 2021
mina86 added a commit to mina86/nearcore that referenced this issue Dec 7, 2021
@mina86
pytest: rosetta: add tests for looking at transactions
1adc28d 
Issue: near#5173
Issue: near#3186
@frol
Copy link
Collaborator

frol commented Dec 7, 2021 •
edited
Loading

@mina86 Well, actually, we needed to integrate the official Rosetta compliance checks: https://github.com/coinbase/rosetta-cli#checkdata (check:data and check:construction): #3186 (comment)

P.S. You may create a new issue if you want to separate the concerns

@frol frol reopened this Dec 7, 2021
near-bulldozer bot pushed a commit that referenced this issue Dec 7, 2021
@mina86
pytest: kill node process through Popen class and then wait for it (#…
7bf068a 
…5578)

This fixes the following warning:

    ../usr/lib/python3.9/subprocess.py:1052: ResourceWarning: subprocess 91224 is still running
      _warn("subprocess %s is still running" % self.pid,

which is caused by LocalNode not waiting for the thread to terminate
after it’s killed.

Issue: #3186
Issue: #4618
near-bulldozer bot pushed a commit that referenced this issue Dec 7, 2021
@mina86
pytest: rosetta: add more tests checking how transactions look (#5686)
a047205 
Extend implicit account test to also investigate how the NEAR
transactions look when fetched through the Rosetta Data API.

Issue: #5173
Issue: #3186
@stale
Copy link

stale bot commented Mar 7, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Mar 7, 2022
@bowenwang1996 bowenwang1996 removed S-stale T-public-interfaces Team: issues relevant to the public interfaces team labels Mar 9, 2022
@mina86 mina86 added the T-public-interfaces Team: issues relevant to the public interfaces team label Apr 15, 2022
@bowenwang1996 bowenwang1996 removed the T-public-interfaces Team: issues relevant to the public interfaces team label Apr 18, 2022
@firatNEAR firatNEAR added the T-integrations Team: issues relevant to the integrations team label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@firatNEAR firatNEAR

Labels
A-CI Area: Continuous Integration A-RPC Area: rpc A-testing Area: Unit testing / integration testing T-integrations Team: issues relevant to the integrations team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@mina86 @frol @khorolets @bowenwang1996 @MaksymZavershynskyi @firatNEAR