pytest: rosetta: add more tests checking how transactions look #5686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
added
A-testing
bowenwang1996
approved these changes
Dec 7, 2021
frol
approved these changes
Dec 7, 2021
mm-near
reviewed
Dec 7, 2021
| def test_delete_implicit_account(self) -> None: | ||
| def _get_account_balance(self, | ||
| account: key.Key, | ||
| require: bool = True) -> typing.Optional[int]: |
There was a problem hiding this comment.
nit:
you can do at the top of the file:
from typing import Optional
There was a problem hiding this comment.
This is bigger discussion I suppose. Throughout all the code (in nearcore and nayduck) I’ve been using typing.xxx so this preserves that style. If we want to change this we should apply the style equally to all code in separate PR.
mm-near
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend implicit account test to also investigate how the NEAR
transactions look when fetched through the Rosetta Data API.
Issue: #5173
Issue: #3186