pytest: kill node process through Popen class and then wait for it #5578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following warning when trying to run tests with
unittest fixture:
sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mpn/.near/test0/stdout' mode='a' encoding='UTF-8'>
sys:1: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mpn/.near/test0/stderr' mode='a' encoding='UTF-8'>
Issue: near#3186
Issue: near#4618
mina86
added
A-testing
|
Note: This is on top of #5576 so look at the second commit only. |
mm-near
suggested changes
Dec 2, 2021
pytest/lib/cluster.py
Outdated
| @@ -398,24 +398,25 @@ def start(self, *, boot_node: BootNode = None, skip_starting_proxy=False): | |||
| except: | |||
| logger.error( | |||
| '=== failed to start node, rpc does not ready in 10 seconds') | |||
| self.stdout.close() | |||
| self.stderr.close() | |||
| if os.environ.get('BUILDKITE'): | |||
There was a problem hiding this comment.
please comment what is the special thing that we need to do for 'BUILDKITE'
There was a problem hiding this comment.
With the other PR merged this PR no longer touches this piece of code so documenting this here feels out of place for this PR.
|
@mm-near, PTAL |
mm-near
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following warning:
which is caused by LocalNode not waiting for the thread to terminate
after it’s killed.
Issue: #3186
Issue: #4618