Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix disappearing NDV header in code nodes #7290

Merged
merged 9 commits into from
Oct 5, 2023
Merged

fix(editor): Fix disappearing NDV header in code nodes #7290

merged 9 commits into from
Oct 5, 2023

Conversation

MiloradFilipovic
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@MiloradFilipovic MiloradFilipovic self-assigned this Sep 28, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6d3d178) 33.30% compared to head (ba6b0ad) 33.29%.
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7290      +/-   ##
==========================================
- Coverage   33.30%   33.29%   -0.01%     
==========================================
  Files        3376     3376              
  Lines      205767   205766       -1     
  Branches    22159    22153       -6     
==========================================
- Hits        68524    68511      -13     
- Misses     136129   136141      +12     
  Partials     1114     1114
Files Coverage Δ
packages/editor-ui/src/components/NodeSettings.vue 38.20% <100.00%> (-0.06%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Sep 29, 2023 •
edited
Loading

1 flaky test on run #2376 ↗︎

0 245 3 0 Flakiness 1

Details:

🌳 ADO-1126-ndv-header-scroll-fix 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradF...
Project: n8n Commit: ba6b0ad1cc
Status: Passed Duration: 08:50 💡
Started: Oct 5, 2023 10:13 AM Ended: Oct 5, 2023 10:22 AM
Flakiness  cypress/e2e/28-debug.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Debug > should be able to debug executions Output Screenshots Video

Review all test suite changes for PR #7290 ↗︎

alexgrozav
alexgrozav previously approved these changes Sep 29, 2023
View reviewed changes
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@MiloradFilipovic
Merge branch 'master' into ADO-1126-ndv-header-scroll-fix
0c2aec9 
* master:
  fix(editor): Separate cloud endpoint calls (#7312)
  fix(core): Account for itemless case on restoring binary data ID (#7305)
  feat(editor): Workflow history [WIP]- create workflow history list component (no-changelog) (#7186)
  feat(core): Add plan name to telemetry (no-changelog) (#7296)
  ci: Fix typescript incremental builds (no-changelog) (#7275)
  fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression (#7300)
  fix(Notion Node): Rename Notion API Key to Internal Integration Token (#7176)
  🚀 Release 1.9.0 (#7288)
  ci: Refactor DB tests (no-changelog) (#7292)
  fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors (#7293)
  fix(Respond to Webhook Node): JSON output from expression fix (#7294)
  feat(core): Add secrets provider reload and refactor (#7277)
mutdmour
mutdmour previously approved these changes Oct 2, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

netroy
netroy previously approved these changes Oct 4, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 7ebf8f3 into master Oct 5, 2023
54 of 55 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-1126-ndv-header-scroll-fix branch October 5, 2023 10:31
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Merged
krynble added a commit that referenced this pull request Oct 5, 2023
@github-actions @krynble
🚀 Release 1.10.0 (#7350)
aa1bf95 
# [1.10.0](https://github.com/n8n-io/n8n/compare/n8n@1.9.0...n8n@1.10.0)
(2023-10-05)


### Bug Fixes

* **Convert to/from binary data Node:** Rename 'Move Binary Data' to
'Convert to/from binary data'
([#7318](#7318))
([5e6c1d4](5e6c1d4))
* **core:** Account for itemless case on restoring binary data ID
([#7305](#7305))
([1691223](1691223))
* **core:** Fix pruning of non-finished executions
([#7333](#7333))
([1b4848a](1b4848a))
* **editor:** Disable email confirmation banner for trialing users
([#7340](#7340))
([6d3d178](6d3d178))
* **editor:** Display value of selected matching column in RMC
([#7298](#7298))
([3aac22b](3aac22b))
* **editor:** Fix canvas endpoint snapping when dragging connection
([#7346](#7346))
([b59b908](b59b908))
* **editor:** Fix disappearing NDV header in code nodes
([#7290](#7290))
([7ebf8f3](7ebf8f3))
* **editor:** Fix RLC not loading when an expression can't resolve
([#7295](#7295))
([ddc26c2](ddc26c2))
* **editor:** Separate cloud endpoint calls
([#7312](#7312))
([04dfcd7](04dfcd7))
* **Jira Software Node:** Get all users in dropdown/RLC
([#7322](#7322))
([3704760](3704760)),
closes [#2670](#2670)
* **Notion Node:** Rename Notion API Key to Internal Integration Token
([#7176](#7176))
([ec2aa38](ec2aa38))
* **Postgres Node:** Node requires comma-separated string even when
using a single parameter through an expression
([#7300](#7300))
([763d451](763d451))
* **Set Node:** Do not stringify null and undefined
([#7313](#7313))
([f0a6687](f0a6687))
* **Typeform Trigger Node:** Change output format for TypeForm trigger
to object instead of array
([#7315](#7315))
([b3fc00e](b3fc00e))


### Features

* **core:** Add "Sent by n8n" attribution
([#7183](#7183))
([8f9fe62](8f9fe62))
* **core:** Add support for building LLM applications
([#7235](#7235))
([00a4b8b](00a4b8b)),
closes [#7246](#7246)
[#7137](#7137)
* Workflow History pruning and prune time settings
([#7343](#7343))
([0adc533](0adc533))

Co-authored-by: krynble <krynble@users.noreply.github.com>
netroy added a commit that referenced this pull request Oct 9, 2023
@MiloradFilipovic @netroy
fix(editor): Fix disappearing NDV header in code nodes (#7290)
7d87392 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
Merged
netroy added a commit that referenced this pull request Oct 9, 2023
@github-actions @netroy
🚀 Release 1.9.2 (#7387)
4777333 
## [1.9.2](https://github.com/n8n-io/n8n/compare/n8n@1.9.1...n8n@1.9.2)
(2023-10-09)


### Bug Fixes

* **core:** Add an option to enable postgres ssl with default certs
([#6889](#6889))
([0de6d7d](0de6d7d))
* **editor:** Fix disappearing NDV header in code nodes
([#7290](#7290))
([7d87392](7d87392))
* **editor:** Remove excess margin below run data editor
([#7372](#7372))
([8c38984](8c38984))
* **editor:** Use display option's @Version specifier
([#7351](#7351))
([73a98cb](73a98cb))
* **Google BigQuery Node:** Location default to jobReference
([#7354](#7354))
([489a12d](489a12d))
* **Google Drive Trigger Node:** Add Shared Drives support
([#7369](#7369))
([138d26c](138d26c))
* **Google Sheets Node:** Fix "Maximum call stack size exceeded" error
on too many rows ([#7384](#7384))
([200fb54](200fb54))
* **HTML Node:** Update property fields to not use expressions on drag
([#7379](#7379))
([4517001](4517001))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Oct 10, 2023

Got released with n8n@1.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

@netroy netroy netroy left review comments

@mutdmour mutdmour mutdmour left review comments

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MiloradFilipovic @janober @netroy @mutdmour @alexgrozav