Skip to content

Commit

Permalink
fix(Convert to/from binary data Node): Rename 'Move Binary Data' to '…
Browse files Browse the repository at this point in the history
…Convert to/from binary data' (#7318)

Github issue / Community forum post (link here to close automatically):
  • Loading branch information
elsmr authored Oct 4, 2023
1 parent b3fc00e commit 5e6c1d4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cypress/e2e/16-webhook-node.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,10 @@ describe('Webhook Trigger node', async () => {

ndv.getters.backToCanvas().click();

workflowPage.actions.addNodeToCanvas('Move Binary Data');
workflowPage.actions.addNodeToCanvas('Convert to/from binary data');
workflowPage.actions.zoomToFit();

workflowPage.actions.openNode('Move Binary Data');
workflowPage.actions.openNode('Convert to/from binary data');
cy.getByTestId('parameter-input-mode').click();
getVisibleSelect().find('.option-headline').contains('JSON to Binary').click();
ndv.getters.backToCanvas().click();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@
},
"subcategories": {
"Core Nodes": ["Files"]
}
},
"alias": ["Move Binary Data"]
}
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,15 @@ encodeDecodeOptions.sort((a, b) => {

export class MoveBinaryData implements INodeType {
description: INodeTypeDescription = {
displayName: 'Move Binary Data',
displayName: 'Convert to/from binary data',
name: 'moveBinaryData',
icon: 'fa:exchange-alt',
group: ['transform'],
version: 1,
subtitle: '={{$parameter["mode"]==="binaryToJson" ? "Binary to JSON" : "JSON to Binary"}}',
description: 'Move data between binary and JSON properties',
defaults: {
name: 'Move Binary Data',
name: 'Convert to/from binary data',
color: '#7722CC',
},
inputs: ['main'],
Expand Down

0 comments on commit 5e6c1d4

Please sign in to comment.