Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors #7293

Merged

Conversation

maspio
Copy link
Contributor

@maspio maspio commented Sep 28, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (53a7502) 33.04% compared to head (e31cda5) 33.10%.

❗ Current head e31cda5 differs from pull request most recent head 128fbd1. Consider uploading reports for the commit 128fbd1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7293      +/-   ##
==========================================
+ Coverage   33.04%   33.10%   +0.06%     
==========================================
  Files        3360     3360              
  Lines      200362   200364       +2     
  Branches    21994    21997       +3     
==========================================
+ Hits        66201    66323     +122     
+ Misses     133051   132931     -120     
  Partials     1110     1110              
Files Coverage Δ
packages/workflow/src/NodeErrors.ts 63.63% <ø> (ø)
...es-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts 33.11% <0.00%> (-0.23%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 28, 2023

Passing run #2312 ↗︎

0 242 3 0 Flakiness 0

Details:

🌳 node-712-suggest-fix-for-too-many-requests-in-the-http-node 🖥️ browsers:node...
Project: n8n Commit: 128fbd1791
Status: Passed Duration: 08:25 💡
Started: Sep 28, 2023 1:17 PM Ended: Sep 28, 2023 1:25 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Sep 28, 2023
Copy link
Contributor

@michael-radency michael-radency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@maspio maspio merged commit 0bc33b1 into master Sep 28, 2023
66 checks passed
@maspio maspio deleted the node-712-suggest-fix-for-too-many-requests-in-the-http-node branch September 28, 2023 14:00
@github-actions github-actions bot mentioned this pull request Sep 28, 2023
netroy added a commit that referenced this pull request Sep 28, 2023
# [1.9.0](https://github.com/n8n-io/n8n/compare/n8n@1.8.0...n8n@1.9.0)
(2023-09-28)


### Bug Fixes

* **Airtable Node:** Attachments field type fix
([#7227](#7227))
([2af967c](2af967c))
* **core:** Change WorkflowHistory nodes/connections columns to be json
([#7282](#7282))
([a80abad](a80abad))
* **core:** Fix binary data manager check on pruning
([#7251](#7251))
([484035e](484035e))
* **core:** Fix missing execution ID in webhook-based workflow producing
binary data ([#7244](#7244))
([33991e9](33991e9))
* **core:** Handle filename* with quotes in Content-Disposition header
([#7229](#7229))
([67b985f](67b985f))
* **core:** Make DNS resolution order configurable
([#7272](#7272))
([5b3121c](5b3121c))
* **core:** Make senderId required for all command messages
([#7252](#7252))
([4b01428](4b01428))
* **core:** Prevent executions from displaying Running status
incorrectly ([#7261](#7261))
([861cac5](861cac5))
* **core:** Use consistent timezone-aware timestamps in postgres
([#6948](#6948))
([0132514](0132514)),
closes [#2178](#2178)
[#2810](#2810)
[#3855](#3855)
[#2813](#2813)
* **editor:** Add debug feature docs link
([#7240](#7240))
([4614e1e](4614e1e))
* **editor:** Fix SQL editor issue
([#7236](#7236))
([647fc6c](647fc6c))
* **editor:** Ensure new Set node is on top of search list
([#7215](#7215))
([2491ccf](2491ccf))
* **editor:** Forbid password reset when cloud account is limited in the
number of users [7188](#7188)
([303bc8e](303bc8e))
* **HTTP Request Node:** Add suggestion how to fix '429 - too many
requests' errors ([#7293](#7293))
([0bc33b1](0bc33b1))
* **Item Lists Node:** Concatenate operation pairedItems fix
([#7286](#7286))
([cde23a1](cde23a1))
* **Respond to Webhook Node:** JSON output from expression fix
([#7294](#7294))
([8bc369d](8bc369d))


### Features

* Add onboarding flow
([#7212](#7212))
([01e9340](01e9340))
* **core:** Add secrets provider reload and refactor
([#7277](#7277))
([53a7502](53a7502))
* **core:** Add Tournament as the new default expression evaluator
([#6964](#6964))
([bf74f09](bf74f09))
* **core:** Initial workflow history API
([#7234](#7234))
([0083a9e](0083a9e))
* **core:** Introduce object store service
([#7225](#7225))
([fa84545](fa84545))
* **editor:** Add user cloud ID to telemetry
[#7232](#7232)
([60c152d](60c152d))
* **editor:** Rework banners framework and add email confirmation banner
([#7205](#7205))
([b0e98b5](b0e98b5))
* **MISP Node:** Update credential to support HTTP Request node
([#7268](#7268))
([e4c302c](e4c302c))


### Performance Improvements

* **core:** Skip unneeded calls on every pruning cycle
([#7260](#7260))
([db01164](db01164))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 28, 2023

Got released with n8n@1.9.0

MiloradFilipovic added a commit that referenced this pull request Oct 2, 2023
* master:
  fix(editor): Separate cloud endpoint calls (#7312)
  fix(core): Account for itemless case on restoring binary data ID (#7305)
  feat(editor): Workflow history [WIP]- create workflow history list component (no-changelog) (#7186)
  feat(core): Add plan name to telemetry (no-changelog) (#7296)
  ci: Fix typescript incremental builds (no-changelog) (#7275)
  fix(Postgres Node): Node requires comma-separated string even when using a single parameter through an expression (#7300)
  fix(Notion Node): Rename Notion API Key to Internal Integration Token (#7176)
  🚀 Release 1.9.0 (#7288)
  ci: Refactor DB tests (no-changelog) (#7292)
  fix(HTTP Request Node): Add suggestion how to fix '429 - too many requests' errors (#7293)
  fix(Respond to Webhook Node): JSON output from expression fix (#7294)
  feat(core): Add secrets provider reload and refactor (#7277)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants