Input by duration: various fixes #26367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
4 tasks
Contributor
mathesoncalum
approved these changes
Feb 7, 2025
Contributor
mathesoncalum
left a comment
mathesoncalum
left a comment
There was a problem hiding this comment.
All good!
My only question is whether m_rest in input.h is still necessary? It looks very closely linked to m_notes.empty() now (not a blocker).
RomanPudashkin
force-pushed
the
input_by_duration_fixes
branch
from
b00dca8 to
a193790
Compare
Contributor
|
Apart from @DmitryArefiev's comment, I've tested all of the above and they appear fixed (MacOS only). All that's left of the issues I logged is this one, which @bkunda and I discussed and agreed should be done. |
RomanPudashkin
force-pushed
the
input_by_duration_fixes
branch
from
d30eaac to
b8387d6
Compare
RomanPudashkin
force-pushed
the
input_by_duration_fixes
branch
from
b8387d6 to
93558c3
Compare
|
Looking better and better each time @RomanPudashkin! I can also see the accidentals showing well. 😌 |
RomanPudashkin
force-pushed
the
input_by_duration_fixes
branch
from
93558c3 to
0335989
Compare
3 tasks
|
@DmitryArefiev #26395 looks good! approved |
4 tasks
RomanPudashkin
force-pushed
the
input_by_duration_fixes
branch
from
0335989 to
f68ed47
Compare
mathesoncalum
approved these changes
Feb 12, 2025
RomanPudashkin
force-pushed
the
input_by_duration_fixes
branch
from
f68ed47 to
ad6b33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26363
Resolves: #26349
Resolves: #26345
Resolves: #26325
Resolves: #26327
Resolves: #26370
Resolves: #26371
Resolves: #26373
Resolves: #26395
Resolves: #26364