Skip to content

Revert upgrade to React 19.1 #17206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Revert upgrade to React 19.1 #17206

merged 1 commit into from
Mar 31, 2025

Conversation

@bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Mar 31, 2025

Revert upgrade to React 19.1 due to increase in runtime for tests.

I'll keep monitoring the situation and upgrade again once the root cause is clear and/or the issue is fixed.

@github-actions
Copy link

github-actions bot commented Mar 31, 2025 •
edited
Loading

Thanks for adding a type label to the PR! 👍

@bernardobelchior bernardobelchior mentioned this pull request Mar 31, 2025
Merged
1 task
@bernardobelchior bernardobelchior added the type: regression A bug, but worse, it used to behave as expected. label Mar 31, 2025
@mui-bot
Copy link

mui-bot commented Mar 31, 2025

Deploy preview: https://deploy-preview-17206--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2ebf04b

@bernardobelchior bernardobelchior marked this pull request as ready for review March 31, 2025 13:25
@bernardobelchior bernardobelchior requested review from a team, JCQuintas and LukasTy March 31, 2025 13:25
@cherniavskii
Copy link
Member

cherniavskii commented Mar 31, 2025

Revert upgrade to React 19.1 due to increase in runtime for tests.

Do you have any numbers to share?

LukasTy
LukasTy approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any numbers to share?

#17192 (comment)

Maybe the culprit could actually be the new owner stack, which is supposed to be disabled on production, but test build could be treated as development, hence the drastick change. 🤔
It might be worth testing runtime difference with different ENV parameters and potentially opening issue on React side. 🤷

@LukasTy LukasTy merged commit 347f7d6 into mui:master Mar 31, 2025
22 of 23 checks passed
@bernardobelchior
Copy link
Member Author

bernardobelchior commented Mar 31, 2025

Revert upgrade to React 19.1 due to increase in runtime for tests.

Do you have any numbers to share?

Sorry, should have added that information! There's some of it at #17192, but since that commit was merged the tests running on React 19 are taking longer to run (around 5min per run).

@bernardobelchior bernardobelchior deleted the revert-react-19.1 branch March 31, 2025 15:58
arminmeh pushed a commit to arminmeh/mui-x that referenced this pull request Apr 1, 2025
@bernardobelchior @arminmeh
Revert upgrade to React 19.1 (mui#17206)
fa51e72
@bernardobelchior bernardobelchior mentioned this pull request Jun 2, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LukasTy LukasTy LukasTy approved these changes

@JCQuintas JCQuintas JCQuintas approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees

No one assigned

Labels

type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bernardobelchior @mui-bot @cherniavskii @LukasTy @JCQuintas