Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jun 1, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react (source) ^19.0.10 -> ^19.1.6 age adoption passing confidence
@types/react (source) ^19.0.12 -> ^19.1.6 age adoption passing confidence
@types/react-dom (source) ^19.0.4 -> ^19.1.5 age adoption passing confidence
react (source) ^19.0.0 -> ^19.1.0 age adoption passing confidence
react-dom (source) ^19.0.0 -> ^19.1.0 age adoption passing confidence

Release Notes

facebook/react (react)

v19.1.0

Compare Source

facebook/react (react-dom)

v19.1.0

Compare Source


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies. label Jun 1, 2025
@renovate renovate bot force-pushed the renovate/react branch from bc11dda to 509f51c Compare June 1, 2025 09:06
@mui-bot
Copy link

mui-bot commented Jun 1, 2025

Deploy preview: https://deploy-preview-18166--material-ui-x.netlify.app/

Bundle size report

Total Size Change:${\tiny{\color{red}▲}}$+40B(0.00%) - Total Gzip Change:${\tiny{\color{red}▲}}$+48B(0.00%)
Files: 120 total (0 added, 0 removed, 45 changed)

Show 45 more bundle changes

@mui/x-chartsparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts-pro/ChartsToolbarProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-charts-pro/ChartZoomSliderparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/BarChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%)
@mui/x-charts/ChartContainerparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-charts/ChartDataProviderparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-charts/ChartsAxisparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-charts/ChartsAxisHighlightparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/ChartsClipPathparsed:${\tiny{\color{red}▲}}$+2B(+0.03%) gzip:${\tiny{\color{red}▲}}$+4B(+0.13%)
@mui/x-charts/ChartsGridparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/ChartsLegendparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-charts/ChartsOverlayparsed:${\tiny{\color{red}▲}}$+2B(+0.02%) gzip:${\tiny{\color{red}▲}}$+2B(+0.06%)
@mui/x-charts/ChartsReferenceLineparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/ChartsSurfaceparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/ChartsTooltipparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/ChartsXAxisparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-charts/ChartsYAxisparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/Gaugeparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-charts/LineChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/PieChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/RadarChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts/ScatterChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%)
@mui/x-charts/SparkLineChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-tree-viewparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-tree-view-proparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-tree-view-pro/RichTreeViewProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-tree-view/RichTreeViewparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-tree-view/SimpleTreeViewparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%)
@mui/x-tree-view/TreeItemparsed:${\tiny{\color{red}▲}}$+2B(+0.01%) gzip:${\tiny{\color{red}▲}}$+2B(+0.02%)
@mui/x-tree-view/TreeItemProviderparsed:${\tiny{\color{red}▲}}$+2B(+0.03%) gzip:${\tiny{\color{red}▲}}$+2B(+0.07%)
@mui/x-charts-proparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-charts-pro/BarChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%)
@mui/x-charts-pro/ChartContainerProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-3B(-0.01%)
@mui/x-charts-pro/ChartDataProviderProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-charts-pro/FunnelChartparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-charts-pro/Heatmapparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-charts-pro/LineChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/PieChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip: 0B(0.00%)
@mui/x-charts-pro/RadarChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%)
@mui/x-charts-pro/ScatterChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-3B(0.00%)
@mui/x-data-gridparsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%)
@mui/x-data-grid-premiumparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%)
@mui/x-data-grid-premium/DataGridPremiumparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+3B(0.00%)
@mui/x-data-grid-proparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+6B(0.00%)
@mui/x-data-grid-pro/DataGridProparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+4B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 1a133ca

@github-actions
Copy link

github-actions bot commented Jun 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 1, 2025
@renovate renovate bot force-pushed the renovate/react branch from 509f51c to cb383e3 Compare June 1, 2025 10:20
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 1, 2025
@renovate renovate bot force-pushed the renovate/react branch from cb383e3 to 1a133ca Compare June 1, 2025 16:25
@JCQuintas JCQuintas merged commit d8d7972 into master Jun 1, 2025
23 checks passed
@JCQuintas JCQuintas deleted the renovate/react branch June 1, 2025 18:23
@LukasTy
Copy link
Member

LukasTy commented Jun 2, 2025

@JCQuintas I think we agreed to postpone the bump until we find the time to investigate the cause of very significant CI runtime increase. 🤔
#17216
Have you checked it?

It looks like the test_browser is now taking almost double the time, while test_unit increased runtime by ~10%. 🤔 🙈
Screenshot 2025-06-02 at 10 36 18

P.S. More recent test_unit runs are taking even longer. 🤔

@bernardobelchior
Copy link
Member

Last time we reverted this because of the increase in time it took to run test_browser. It seems to have increased from around 7min (run 1, run 2) to around 11min (this PR's run).

From looking at React's issues, there doesn't seem to be any issue mentioning worse performance when running tests, so maybe it's something related to our setup?

@bernardobelchior
Copy link
Member

bernardobelchior commented Jun 2, 2025

Did a small test on my Macbook Pro Apple M4 Pro, 48GB RAM and I can also reproduce the difference locally:

Seconds React 19.1: pnpm test:unit:browser --coverage React 19.0: pnpm test:unit:browser --coverage React 19.1: pnpm test:unit:browser React 19.0: pnpm test:unit:browser
Run 1 91 85 62 59
Run 2 84 78 56 51
Run 3 84 78 56 52
Run 4 83 78 56 52
Avg [1] 83.67 78 56 51.67

[1] Excluding first run

The results, excluding the first run, are as follows:

  • pnpm test:unit:browser --coverage: React 19.1 is 7.3% slower on average than React 19.0
  • pnpm test:unit:browser: React 19.1 is 8.4% slower on average than React 19.0

On CI, it seems that pnpm test:unit:browser --coverage is around 57% slower when running React 19.1 vs React 19.0.

However, CI's config is slightly different. In CI, we disable file parallelism, run the test inside a single child_process and only use one thread.

@JCQuintas
Copy link
Member

config is slightly different.

You can try CI=true pnpm test:unit:browser --coverage to run the same config as CI

@JCQuintas
Copy link
Member

@JCQuintas I think we agreed to postpone the bump until we find the time to investigate the cause of very significant CI runtime increase. 🤔 #17216 Have you checked it?

TBH I completely forgot about this. 😢

It didn't have a "request for change" so I assumed it was good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update of dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants