Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 30, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react (source) ^19.0.0 -> ^19.1.0 age adoption passing confidence
react-dom (source) ^19.0.0 -> ^19.1.0 age adoption passing confidence
react-is (source) ^19.0.0 -> ^19.1.0 age adoption passing confidence

Release Notes

facebook/react (react)

v19.1.0

Compare Source

facebook/react (react-dom)

v19.1.0

Compare Source

facebook/react (react-is)

v19.1.0

Compare Source

Owner Stack

An Owner Stack is a string representing the components that are directly responsible for rendering a particular component. You can log Owner Stacks when debugging or use Owner Stacks to enhance error overlays or other development tools. Owner Stacks are only available in development builds. Component Stacks in production are unchanged.

  • An Owner Stack is a development-only stack trace that helps identify which components are responsible for rendering a particular component. An Owner Stack is distinct from a Component Stacks, which shows the hierarchy of components leading to an error.
  • The captureOwnerStack API is only available in development mode and returns a Owner Stack, if available. The API can be used to enhance error overlays or log component relationships when debugging. #​29923, #​32353, #​30306,
    #​32538, #​32529, #​32538
React
  • Enhanced support for Suspense boundaries to be used anywhere, including the client, server, and during hydration. #​32069, #​32163, #​32224, #​32252
  • Reduced unnecessary client rendering through improved hydration scheduling #​31751
  • Increased priority of client rendered Suspense boundaries #​31776
  • Fixed frozen fallback states by rendering unfinished Suspense boundaries on the client. #​31620
  • Reduced garbage collection pressure by improving Suspense boundary retries. #​31667
  • Fixed erroneous “Waiting for Paint” log when the passive effect phase was not delayed #​31526
  • Fixed a regression causing key warnings for flattened positional children in development mode. #​32117
  • Updated useId to use valid CSS selectors, changing format from :r123: to «r123». #​32001
  • Added a dev-only warning for null/undefined created in useEffect, useInsertionEffect, and useLayoutEffect. #​32355
  • Fixed a bug where dev-only methods were exported in production builds. React.act is no longer available in production builds. #​32200
  • Improved consistency across prod and dev to improve compatibility with Google Closure Complier and bindings #​31808
  • Improve passive effect scheduling for consistent task yielding. #​31785
  • Fixed asserts in React Native when passChildrenWhenCloningPersistedNodes is enabled for OffscreenComponent rendering. #​32528
  • Fixed component name resolution for Portal #​32640
  • Added support for beforetoggle and toggle events on the dialog element. #​32479 #​32479
React DOM
  • Fixed double warning when the href attribute is an empty string #​31783
  • Fixed an edge case where getHoistableRoot() didn’t work properly when the container was a Document #​32321
  • Removed support for using HTML comments (e.g. <!-- -->) as a DOM container. #​32250
  • Added support for <script> and <template> tags to be nested within <select> tags. #​31837
  • Fixed responsive images to be preloaded as HTML instead of headers #​32445
use-sync-external-store
  • Added exports field to package.json for use-sync-external-store to support various entrypoints. #​25231
React Server Components
  • Added unstable_prerender, a new experimental API for prerendering React Server Components on the server #​31724
  • Fixed an issue where streams would hang when receiving new chunks after a global error #​31840, #​31851
  • Fixed an issue where pending chunks were counted twice. #​31833
  • Added support for streaming in edge environments #​31852
  • Added support for sending custom error names from a server so that they are available in the client for console replaying. #​32116
  • Updated the server component wire format to remove IDs for hints and console.log because they have no return value #​31671
  • Exposed registerServerReference in client builds to handle server references in different environments. #​32534
  • Added react-server-dom-parcel package which integrates Server Components with the Parcel bundler #​31725, #​32132, #​31799, #​32294, #​31741

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies. label Mar 30, 2025
@mui-bot
Copy link

mui-bot commented Mar 30, 2025

Deploy preview: https://deploy-preview-17192--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 40c6d69

@bernardobelchior
Copy link
Member

Tests failing due to:

Updated useId to use valid CSS selectors, changing format from :r123: to «r123». facebook/react#32001

Release notes

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 31, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@renovate renovate bot force-pushed the renovate/react branch from d081574 to 7e5a5d8 Compare March 31, 2025 08:31
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 31, 2025
@renovate
Copy link
Contributor Author

renovate bot commented Mar 31, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@bernardobelchior bernardobelchior requested a review from a team March 31, 2025 11:26
@bernardobelchior bernardobelchior merged commit 42cc71e into master Mar 31, 2025
21 checks passed
@bernardobelchior bernardobelchior deleted the renovate/react branch March 31, 2025 11:30
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked what could be causing such an increase in the runtime of unit tests? 🤔
That doesn't look fun... Over 20 minutes. 🙈

@LukasTy
Copy link
Member

LukasTy commented Mar 31, 2025

Maybe the increased runtime was a fluke, let's monitor how it behaves on master and new PRs and adjust accordingly. 👌

@JCQuintas
Copy link
Member

Have you checked what could be causing such an increase in the runtime of unit tests? 🤔 That doesn't look fun... Over 20 minutes. 🙈

Oooh I didn't check that.

It is possible the new OwnerState feature adds instrumentation that slows down tests, though its just a guess right now

@LukasTy
Copy link
Member

LukasTy commented Mar 31, 2025

It is possible the new OwnerState feature adds instrumentation that slows down tests, though its just a guess right now

It could be. 🤔
It was not a fluke, unit tests on CI are way slower (an increase from 13-15 mins to 23 😱 ). 🙈
The Charts performance analysis also shows substantial performance reduction. 🤔

It looks like we need more exploration to understand:

  • is it warranted based on certain change?
  • can we make some changes to avoid the significant performance degradation?
  • is it a bug in the React release?

@bernardobelchior
Copy link
Member

Have you checked what could be causing such an increase in the runtime of unit tests? 🤔 That doesn't look fun... Over 20 minutes. 🙈

Sorry, I didn't check that.

The Charts performance analysis also shows substantial performance reduction. 🤔

Any reason why this analysis wasn't posted as a comment? I didn't see it, so I assumed things were ok.

is it warranted based on certain change?
can we make some changes to avoid the significant performance degradation?

I'll investigate this

@LukasTy
Copy link
Member

LukasTy commented Mar 31, 2025

The Charts performance analysis also shows substantial performance reduction. 🤔

Any reason why this analysis wasn't posted as a comment? I didn't see it, so I assumed things were ok.

I assume that the PR didn't touch Charts code, hence, it didn't run, but it always runs on master. 🤔

@bernardobelchior
Copy link
Member

Reverting to v19.0 while I investigate what's going on: #17206

arminmeh pushed a commit to arminmeh/mui-x that referenced this pull request Apr 1, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Bernardo Belchior <bernardo@mui.com>
expect(menu.id).to.match(/[«|:]r[0-9a-z]+[»|:]/);
});
expect(menu.getAttribute('aria-labelledby')).to.match(/:r[0-9a-z]+:/);
expect(menu.getAttribute('aria-labelledby')).to.match(/[«|:]r[0-9a-z]+[»|:]/);
Copy link
Member

@oliviertassinari oliviertassinari Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test looks very much like we test implementation details 😁. I imagine we could rewrite it to test what we really want to test and work regardless of what the id structure is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! 💯
@mui/xgrid would it be possible to use the toHaveAccessibleName assertion in this case? 🤔

@bernardobelchior bernardobelchior mentioned this pull request Apr 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Update of dependencies.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants