-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Bump React to ^19.1.0 #17192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump React to ^19.1.0 #17192
Conversation
|
Deploy preview: https://deploy-preview-17192--material-ui-x.netlify.app/ |
|
Tests failing due to:
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
d081574 to
7e5a5d8
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
9c21dba to
cfa4c67
Compare
a2b03c3 to
40c6d69
Compare
LukasTy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked what could be causing such an increase in the runtime of unit tests? 🤔
That doesn't look fun... Over 20 minutes. 🙈
|
Maybe the increased runtime was a fluke, let's monitor how it behaves on master and new PRs and adjust accordingly. 👌 |
Oooh I didn't check that. It is possible the new OwnerState feature adds instrumentation that slows down tests, though its just a guess right now |
It could be. 🤔 It looks like we need more exploration to understand:
|
Sorry, I didn't check that.
Any reason why this analysis wasn't posted as a comment? I didn't see it, so I assumed things were ok.
I'll investigate this |
I assume that the PR didn't touch Charts code, hence, it didn't run, but it always runs on master. 🤔 |
|
Reverting to v19.0 while I investigate what's going on: #17206 |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Bernardo Belchior <bernardo@mui.com>
| expect(menu.id).to.match(/[«|:]r[0-9a-z]+[»|:]/); | ||
| }); | ||
| expect(menu.getAttribute('aria-labelledby')).to.match(/:r[0-9a-z]+:/); | ||
| expect(menu.getAttribute('aria-labelledby')).to.match(/[«|:]r[0-9a-z]+[»|:]/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test looks very much like we test implementation details 😁. I imagine we could rewrite it to test what we really want to test and work regardless of what the id structure is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! 💯
@mui/xgrid would it be possible to use the toHaveAccessibleName assertion in this case? 🤔
This PR contains the following updates:
^19.0.0->^19.1.0^19.0.0->^19.1.0^19.0.0->^19.1.0Release Notes
facebook/react (react)
v19.1.0Compare Source
facebook/react (react-dom)
v19.1.0Compare Source
facebook/react (react-is)
v19.1.0Compare Source
Owner Stack
An Owner Stack is a string representing the components that are directly responsible for rendering a particular component. You can log Owner Stacks when debugging or use Owner Stacks to enhance error overlays or other development tools. Owner Stacks are only available in development builds. Component Stacks in production are unchanged.
#32538, #32529, #32538
React
useIdto use valid CSS selectors, changing format from:r123:to«r123». #32001React DOM
hrefattribute is an empty string #31783getHoistableRoot()didn’t work properly when the container was a Document #32321<!-- -->) as a DOM container. #32250<script>and<template>tags to be nested within<select>tags. #31837use-sync-external-store
exportsfield topackage.jsonforuse-sync-external-storeto support various entrypoints. #25231React Server Components
unstable_prerender, a new experimental API for prerendering React Server Components on the server #31724registerServerReferencein client builds to handle server references in different environments. #32534Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.