[internal] Improve useControlled() strict mode handling #46807
Merged
+48
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
type: bug
Netlify deploy previewhttps://deploy-preview-46807--material-ui.netlify.app/ Bundle size report
|
oliviertassinari
force-pushed
the
useControlled-improve-strict-mode-handling
branch
from
9e5a62c to
3b52cff
Compare
oliviertassinari
changed the title
Signed-off-by: Olivier Tassinari <oliviertassinari@users.noreply.github.com>
oliviertassinari
deleted the
useControlled-improve-strict-mode-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #46804 at the root (where the test case comes from). As you can see with the failing test case added, when an array is provided, React in strict mode will render twice, the instances will be different, and the warning triggers.
Considering that the effect depends on JSON.stringify, the comparison should continue to use it to fix the Strict Mode support.
The alternative solution is to remove JSON.stringify altogether, and have developers using this utility guarantee that the default value never changes; however, the warning was added to help developers spot cases where they do clearly stupid things, it's not about being a purist. We should keep it easy, so not go down this path.
For those worried about JSON.stringify performance, a cool one: https://v8.dev/blog/json-stringify.