[internal] Improve useControlled() strict mode handling (#46807)

Signed-off-by: Olivier Tassinari <oliviertassinari@users.noreply.github.com>

Author: oliviertassinari

packages/mui-utils/src/useControlled/useControlled.test.tsx

@@ -17,14 +17,14 @@ type TestComponentProps<T> = TestProps<T> & {
 
 type SetProps = <T>(props: TestProps<T>) => void;
 
-const TestComponent = <T,>({ value: valueProp, defaultValue, children }: TestComponentProps<T>) => {
+function TestComponent<T>({ value: valueProp, defaultValue, children }: TestComponentProps<T>) {
   const [value, setValue] = useControlled({
     controlled: valueProp,
     default: defaultValue,
     name: 'TestComponent',
   });
   return children({ value, setValue });
-};
+}
 
 describe('useControlled', () => {
   const { render } = createRenderer();
@@ -90,39 +90,56 @@ describe('useControlled', () => {
     );
   });
 
-  it('warns when changing the defaultValue prop after initial rendering', () => {
-    let setProps: SetProps;
+  describe('warns when changing the defaultValue prop after initial rendering', () => {
+    it('should detect changes', () => {
+      let setProps: SetProps;
 
-    expect(() => {
-      ({ setProps } = render(<TestComponent>{() => null}</TestComponent>));
-    }).not.toErrorDev();
+      expect(() => {
+        ({ setProps } = render(<TestComponent>{() => null}</TestComponent>));
+      }).not.toErrorDev();
 
-    expect(() => {
-      setProps({ defaultValue: 1 });
-    }).toErrorDev(
-      'MUI: A component is changing the default value state of an uncontrolled TestComponent after being initialized.',
-    );
-  });
+      expect(() => {
+        setProps({ defaultValue: 1 });
+      }).toErrorDev(
+        'MUI: A component is changing the default value state of an uncontrolled TestComponent after being initialized.',
+      );
+    });
 
-  it('should not raise a warning if changing the defaultValue when controlled', () => {
-    let setProps: SetProps;
+    it('should not warn when controlled', () => {
+      let setProps: SetProps;
 
-    expect(() => {
-      ({ setProps } = render(
-        <TestComponent value={1} defaultValue={0}>
-          {() => null}
-        </TestComponent>,
-      ));
-    }).not.toErrorDev();
+      expect(() => {
+        ({ setProps } = render(
+          <TestComponent value={1} defaultValue={0}>
+            {() => null}
+          </TestComponent>,
+        ));
+      }).not.toErrorDev();
 
-    expect(() => {
-      setProps({ defaultValue: 1 });
-    }).not.toErrorDev();
-  });
+      expect(() => {
+        setProps({ defaultValue: 1 });
+      }).not.toErrorDev();
+    });
 
-  it('should not raise a warning if setting NaN as the defaultValue when uncontrolled', () => {
-    expect(() => {
-      render(<TestComponent defaultValue={NaN}>{() => null}</TestComponent>);
-    }).not.toErrorDev();
+    it('should not warn when NaN', () => {
+      expect(() => {
+        render(<TestComponent defaultValue={NaN}>{() => null}</TestComponent>);
+      }).not.toErrorDev();
+    });
+
+    it('should not warn when an array', () => {
+      function TestComponentArray() {
+        useControlled({
+          controlled: undefined,
+          default: [],
+          name: 'TestComponent',
+        });
+        return null;
+      }
+
+      expect(() => {
+        render(<TestComponentArray />);
+      }).not.toErrorDev();
+    });
   });
 });

packages/mui-utils/src/useControlled/useControlled.ts

@@ -52,9 +52,7 @@ export default function useControlled<T = unknown>(
     const { current: defaultValue } = React.useRef(defaultProp);
 
     React.useEffect(() => {
-      // Object.is() is not equivalent to the === operator.
-      // See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is for more details.
-      if (!isControlled && !Object.is(defaultValue, defaultProp)) {
+      if (!isControlled && JSON.stringify(defaultProp) !== JSON.stringify(defaultValue)) {
         console.error(
           [
             `MUI: A component is changing the default ${state} state of an uncontrolled ${name} after being initialized. ` +