[docs][autocomplete] Fix console in unstyled demo #46804
Merged
+78
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Netlify deploy previewBundle size report
|
oliviertassinari
force-pushed
the
autocomplete-fix-warning-default-props
branch
from
392660c to
31c8812
Compare
Co-authored-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com> Signed-off-by: Olivier Tassinari <oliviertassinari@users.noreply.github.com>
oliviertassinari
force-pushed
the
autocomplete-fix-warning-default-props
branch
from
dd22e9a to
5ed090e
Compare
oliviertassinari
force-pushed
the
autocomplete-fix-warning-default-props
branch
from
110277b to
540723d
Compare
ZeeshanTamboli
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this in #46803.
It's coming from this demo: http://0.0.0.0:3000/material-ui/react-autocomplete/#customized-hook.
It seems to be related to how React implements strict mode; it will rerender twice, but in our case, we have a side effect in the way useControlled is implemented. Now, considering that this demo is about allowing developers to create their own general-purpose autocomplete component, it felt like we were falling a bit short, so I updated the demo to better match the problem.
Preview: https://deploy-preview-46804--material-ui.netlify.app/material-ui/react-autocomplete/#customized-hook
I have also made a second commit to migrate #45387