fix(guards): mypy resolves autobot_shared so enum aliases stay types; the embedding-literal guard covers namespaced ids and the infra builders (#18345)

[mrveiss]

Thinking Path

Two guard and enum issues in one batch (same scope, no shared files with anything in flight):

• types: an enum alias of the canonical Severity used as an annotation is 'not valid as a type' in the backend mypy run (6 instances) #18345: six enum-fork aliases (X = Severity) were reported by the backend mypy run as Variable "…" is not valid as a type, which silently disabled type checking on those fields.
• test(guard): the embedding-model literal guard misses namespaced model ids and other families, and skips two infra roots #18328: the embedding-model literal guard (bug(kb): embedding cache key and generator resolve the embedding model from different config fields #18143) missed namespaced ids, the e5/gte/jina families, and the two infra collection builders.

What Changed

• types: an enum alias of the canonical Severity used as an annotation is 'not valid as a type' in the backend mypy run (6 instances) #18345, the cause (established, not guessed):
  • Reproduction: run from autobot-backend/, mypy cannot resolve autobot_shared. ignore_missing_imports = true then turns Severity into Any, so a module-level alias reads as a variable. Run from the repo root, the same files are clean.
  • Fix, once: mypy_path = "$MYPY_CONFIG_FILE_DIR" in pyproject.toml [tool.mypy]. No per-site changes.
  • The X: TypeAlias = Severity form the issue suggested hides the bug: it reports success while X is silently Any. So it was rejected.
• test(guard): the embedding-model literal guard misses namespaced model ids and other families, and skips two infra roots #18328:
  • One prefix list: KNOWN_EMBEDDING_MODEL_PREFIXES and is_embedding_model_id() in autobot_shared/embedding_model.py, now the only embedding-family list (the guard's old regex is deleted). It allows an optional org/ namespace and covers the e5/gte/jina, multi-qa- and codebert families. A reranker (bge-reranker-*) shares the bge- prefix but is excluded.
  • Roots gain autobot-infrastructure/shared/scripts/populate_kb_chromadb.py and autobot-infrastructure/shared/tools/index_documentation.py. The issue named a wrapper with no literal; the real collection builder is the shared/tools copy.
  • New hits, classified per bug(kb): embedding cache key and generator resolve the embedding model from different config fields #18143:
    • Both builders → active, so they now call active_embedding_model() instead of "nomic-embed-text". They write autobot_docs, which is not in knowledge/index_embedding_space.py and is read by doc_searcher.py with active_embedding_model() plus a stored-dimension check. The old literal is what could mismatch.
    • code_embedding_generator.py microsoft/codebert-base → index-bound (CODE_INDEX).
    • pinned_model_registry.py → not-a-choice (a revision/digest pin).
  • reach_scope_claim_17844 is updated for the new roots.

Verification

• types: an enum alias of the canonical Severity used as an annotation is 'not valid as a type' in the backend mypy run (6 instances) #18345 pin: repo_tests/mypy_enum_alias_resolution_18345_test.py (3 tests, about 11 s) runs mypy on a fixture from a non-root cwd with the repo config and asserts no valid-type. Its contrast (a config without mypy_path) asserts valid-type appears.
• Strict autobot_shared/ mypy gate unchanged: over all 391 files, origin/main and HEAD both give "86 errors in 17 files", with identical sorted error lists.
• test(guard): the embedding-model literal guard misses namespaced model ids and other families, and skips two infra roots #18328 contrasts: detected are sentence-transformers/all-MiniLM-L6-v2, BAAI/bge-small-en-v1.5, microsoft/codebert-base, intfloat/e5-large-v2, thenlper/gte-base and jinaai/jina-embeddings-v2-base-en. Not matched are meta-llama/…, mistralai/…, microsoft/phi-3-mini, BAAI/bge-reranker-v2-m3, llama3:8b and a bare gte. Mutation (removing the reranker exclusion) fails that case.
• Floor: embedding-model-literal-sites is re-pinned mid-window, 2595 → 2604 (population 2754, window 2454..2754).
• Results:
  • reach_declarations + reach_scope_claim + both guards: 559 passed.
  • After the reranker change, the embedding guard alone: 28 tests passed.
  • code_intelligence tests for the six modules: 207 passed.
  • Sonnet gate: APPROVE.

Risks

• Backend/SLM informational mypy runs now resolve autobot_shared. That is not a gate (GH#7105), so their counts may shift; this was not measured.
• The two infra builders follow the configured embedding model rather than a pinned literal, which is the bug(kb): embedding cache key and generator resolve the embedding model from different config fields #18143 rule for active collections.

Model Used

Anthropic Claude Opus 5.5 (claude-opus-5-5), coordinating. Anthropic Claude Sonnet 5.5 (claude-sonnet-5-5) subagents for implementation and the gate.

Issue Link

Closes #18345
Closes #18328

Follow-up: #18382, the remaining infra nomic-embed-text literals outside the guard's roots.

Changelog fragment

• N/A (type-checker configuration and a repo guard; no runtime change apart from the two infra builders reading the configured embedding model)

Summary by CodeRabbit

• Bug Fixes
  • Knowledge base and documentation indexing now use the active embedding model instead of a fixed default. This keeps indexing aligned with the model configured for the application and avoids inconsistencies when a different supported embedding model is selected.
  • Supported embedding model identifiers are now recognised more consistently, including namespaced identifiers, while chat and malformed identifiers are excluded.

[github-actions]

Notice: 28 open PRs — past the runaway threshold (25)

This is not a request to defer this PR. The actual limit is the open-PR cap (AUTOBOT_OPEN_PR_CAP, default 40), enforced at pre-push against NEW branches only -- pushing more commits to this PR's own branch is never blocked by it.

This notice only means the count is high enough to be worth a glance for a runaway — something opening PRs in a loop, or a merge pipeline that has stalled so nothing is draining.

Currently open:

• test(tools): differential test of the tool-approval planes (#13416) #18387 test(tools): differential test of the tool-approval planes (test(security): the two tool-approval planes are never compared — add a differential assertion #13416)
• refactor(infra): classify 43 more infra scripts by runtime, repair 3 validators (#18289) #18380 refactor(infra): classify 43 more infra scripts by runtime, repair 3 validators (infra: 98 more infrastructure modules import backend-only packages — classify each as shared, backend tool or dead (#18288 follow-up) #18289)
• chore(train): merge train 2026-10-12 #6b — 6 approved PRs incl. the #18359 injection fix (#18359) #18379 chore(train): merge train 2026-10-12 #6b — 6 approved PRs incl. the security(slm): remote command injection — service_name from the URL path is interpolated unquoted into an ssh 'sudo -n systemctl' shell command (reachable by admin/operator users) #18359 injection fix (security(slm): remote command injection — service_name from the URL path is interpolated unquoted into an ssh 'sudo -n systemctl' shell command (reachable by admin/operator users) #18359)
• feat(shell): Refined UI step 2: top nav and icon cluster, Minimal/Full mode, Appearance settings, one brand mark (#18240) #18373 feat(shell): Refined UI step 2: top nav and icon cluster, Minimal/Full mode, Appearance settings, one brand mark (Refined UI step 2 · shell: top nav, UI mode, profile appearance #18240)
• security(api): RUM split into admin, user and bounded-open routes, and Prometheus metrics behind an SLM-issued scrape token (#16375) #18372 security(api): RUM split into admin, user and bounded-open routes, and Prometheus metrics behind an SLM-issued scrape token (security(api): 44 config-registered routers declare no auth gate, triaged by exposure (found by widening the router-auth guard, #16368) #16375)
• refactor(config): the #18094 de-fork remainder — one key reader, one feature flag, one language detector, and image-gen keys vault-first through an origin-bound resolver (#18094) #18371 refactor(config): the tech-debt: forked env defaults, shadowed constants and same-name functions — the remainder after #17419/#16177/#18093 #18094 de-fork remainder — one key reader, one feature flag, one language detector, and image-gen keys vault-first through an origin-bound resolver (tech-debt: forked env defaults, shadowed constants and same-name functions — the remainder after #17419/#16177/#18093 #18094)
• fix(egress): guard the backend services/ outbound calls under the SSOT policy, user-supplied URLs public-only (#17576) #18370 fix(egress): guard the backend services/ outbound calls under the SSOT policy, user-supplied URLs public-only (security(egress): rule 8's only enforcement is a five-file literal, and four connectors beside it call tracked_request unguarded #17576)
• fix(codebase-analytics): honest scan outcomes, duplication detectors wired, and forks shown from the one CI detector (#18013, #18067, #17982) #18362 fix(codebase-analytics): honest scan outcomes, duplication detectors wired, and forks shown from the one CI detector (bug(codebase-analytics): /duplicates returns a fabricated "timed out after 120s" in 0.2s — the single-flight lock is never released #18013, Codebase analytics reports 18,200 problems and zero duplication, while the fork detector finds 365 clusters in the same tree #18067, bug(codebase-analytics): duplicate detection reports 'nothing scanned' as a completed scan — the one tool the dedup programme needs returns nothing for AutoBot's own codebase #17982)
• refactor(regex): one slugify, one skills tokenizer and one word tokenizer, the no-op ANSI copy gone, and the dead command-utils template retired (#18093, #18124) #18360 refactor(regex): one slugify, one skills tokenizer and one word tokenizer, the no-op ANSI copy gone, and the dead command-utils template retired (tech-debt(backend): six regex concepts are forked across 2–8 files each, and one fork is a no-op #18093, tech-debt(code_analysis): a 190-line code-generation template whose output never landed, now stale against the file that did #18124)
• fix(slm): one SSH systemctl executor with quoted, validated units and gated service routes (#18359) #18352 fix(slm): one SSH systemctl executor with quoted, validated units and gated service routes (security(slm): remote command injection — service_name from the URL path is interpolated unquoted into an ssh 'sudo -n systemctl' shell command (reachable by admin/operator users) #18359)
• security(api): gate the 14 remaining ungated mutating routers — sign-in for reads, admin for shared-state writes (#16375) #18351 security(api): gate the 14 remaining ungated mutating routers — sign-in for reads, admin for shared-state writes (security(api): 44 config-registered routers declare no auth gate, triaged by exposure (found by widening the router-auth guard, #16368) #16375)
• refactor(knowledge): the pattern analyzer and Notion connector use the one content digest (#15722) #18350 refactor(knowledge): the pattern analyzer and Notion connector use the one content digest (canonical(knowledge): two functions named content_hash return different values — full digest vs 16-char truncation #15722)
• refactor(audit): audit_logs is the one system of record, Redis its projection — three stores retired, one write path, one retention table (#17225) #18343 refactor(audit): audit_logs is the one system of record, Redis its projection — three stores retired, one write path, one retention table (tech-debt(audit): #6475 closed on three parallel audit systems — there are now six #17225)
• security(auth): DB role permissions work, one strict-union permission gate for both services, MFA-pending tokens refused, SSO mints from the real user (#18259, #18321, #18322) #18338 security(auth): DB role permissions work, one strict-union permission gate for both services, MFA-pending tokens refused, SSO mints from the real user (security(rbac): UserService.get_user_permissions reads role.Permission, which does not exist — the DB-backed permission path raises and the middleware denies #18259, security(slm): get_current_user accepts MFA-pending temp tokens as full sessions (#17049 fixed only the backend) #18321, fix(slm-sso): SSO login passes a stand-in user without is_platform_admin to create_token_response, which raises #18322)
• refactor(chat): chat_sessions is the one durable home of a conversation turn; transcripts are read-only legacy, found where they really are (#18293) #18309 refactor(chat): chat_sessions is the one durable home of a conversation turn; transcripts are read-only legacy, found where they really are (canonical(state): every chat turn is persisted twice — chat_sessions and an undeclared transcript store, already diverged once #18293)
• chore(deps): bump the all-dependencies group across 1 directory with 15 updates #18273 chore(deps): bump the all-dependencies group across 1 directory with 15 updates
• fix(sandbox): execution and pooled containers run fully hardened, and no caller can widen their reach (#17267) #18232 fix(sandbox): execution and pooled containers run fully hardened, and no caller can widen their reach (refactor(sandbox): container hardening is copy-pasted across three Docker clients, with a docstring as the only thing preventing drift #17267)
• chore(deps): bump the all-dependencies group in /autobot-infrastructure/autobot-npu-worker/docker with 3 updates #18177 chore(deps): bump the all-dependencies group in /autobot-infrastructure/autobot-npu-worker/docker with 3 updates
• chore(deps): bump the all-dependencies group in /autobot-infrastructure/shared/docker/ai-stack with 4 updates #18176 chore(deps): bump the all-dependencies group in /autobot-infrastructure/shared/docker/ai-stack with 4 updates
• chore(deps): bump actions/upload-artifact from 7.0.1 to 7.0.2 in the all-dependencies group #18175 chore(deps): bump actions/upload-artifact from 7.0.1 to 7.0.2 in the all-dependencies group
• chore(deps): update asyncpg requirement from >=0.31.0 to >=0.32.0 in /autobot-slm-backend in the all-dependencies group #18172 chore(deps): update asyncpg requirement from >=0.31.0 to >=0.32.0 in /autobot-slm-backend in the all-dependencies group
• chore(deps): bump the all-dependencies group across 1 directory with 16 updates #18157 chore(deps): bump the all-dependencies group across 1 directory with 16 updates
• chore(deps): update aiohttp requirement from >=3.14.3 to >=3.14.4 in /autobot-backend/code_analysis in the all-dependencies group across 1 directory #18156 chore(deps): update aiohttp requirement from >=3.14.3 to >=3.14.4 in /autobot-backend/code_analysis in the all-dependencies group across 1 directory
• chore(deps-dev): bump the oxlint group across 1 directory with 2 updates #18152 chore(deps-dev): bump the oxlint group across 1 directory with 2 updates
• chore(deps): update transformers requirement from >=5.18.0 to >=5.19.0 in /autobot-tts-worker in the all-dependencies group across 1 directory #18150 chore(deps): update transformers requirement from >=5.18.0 to >=5.19.0 in /autobot-tts-worker in the all-dependencies group across 1 directory
• chore(deps-dev): bump the all-dependencies group across 1 directory with 2 updates #18149 chore(deps-dev): bump the all-dependencies group across 1 directory with 2 updates
• chore(deps): bump the opentelemetry group across 1 directory with 10 updates #17999 chore(deps): bump the opentelemetry group across 1 directory with 10 updates
• feat(voice): release a reply's opening chunk at a clause or word boundary, and drop indented code from speech (#13103, #17953) #17972 feat(voice): release a reply's opening chunk at a clause or word boundary, and drop indented code from speech (Voice: first audio waits for a full terminated sentence — no sub-sentence fast start #13103, voice: the speech shaper drops ``` fences but still reads ~~~ fences and indented code blocks aloud #17953)

If the queue is draining normally, ignore this. Otherwise:

1. Check whether CI is dispatching at all — see the ci-dispatch-watchdog status on these PRs
2. Merge the ones whose CI has finished and review has passed: gh pr merge <number> --squash --delete-branch
3. Look for a loop opening near-identical PRs

Warn-only runaway detector — .github/workflows/pr-queue-gate.yml. It never blocks a merge.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update embedding-model ID detection and Ollama model selection in two infrastructure scripts. They also set mypy’s import path relative to its configuration file and add regression tests for enum aliases.

Changes

Embedding model coverage and selection

Layer / File(s)	Summary
Model-ID validation and guard coverage autobot_shared/embedding_model.py, repo_tests/embedding_model_literal_guard_18143_test.py, repo_tests/reach_scope_claim_17844_test.py	The literal guard uses a shared predicate to identify embedding-model IDs. It scans the two infrastructure scripts, tests namespaced IDs and additional model families, and rejects chat, reranker, incomplete and malformed IDs.
Dynamic Ollama model selection autobot-infrastructure/shared/scripts/populate_kb_chromadb.py, autobot-infrastructure/shared/tools/index_documentation.py	Both scripts use the model name returned by active_embedding_model() when configuring Ollama embeddings. The base URLs remain unchanged.

Mypy enum alias resolution

Layer / File(s)	Summary
Configuration and alias regression test pyproject.toml, repo_tests/mypy_enum_alias_resolution_18345_test.py	The mypy configuration sets mypy_path to $MYPY_CONFIG_FILE_DIR. Regression tests check enum-alias diagnostics when mypy runs from a temporary directory, including a configuration without mypy_path.

---

Priority: ➖ Normal

Severity of issue fixed: Medium

Merge Risk: 🟡 Moderate · up to 1b6ec

The documentation indexing scripts now follow the configured embedding model but do not check the model used to build their existing collections. Changing the model without rebuilding can break indexing or degrade search results. Resolve this before merging, or confirm that a rebuild is enforced when the model changes. The new mypy test also needs a timeout so a stalled run cannot hang the test suite.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 36.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 6 files. (1 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title accurately summarises both main changes: mypy resolution for enum aliases and expanded embedding-model literal guard coverage. It is specific and clear despite being longer than preferred.
Linked Issues check		The PR meets the coding requirements for [#18345] and [#18328]. For [#18345], mypy_path = "$MYPY_CONFIG_FILE_DIR" fixes the unresolved autobot_shared import from a backend-rooted run. The regressi…
Out of Scope Changes check		The changes stay within the linked issue scope. The mypy configuration and regression test support [#18345]. The shared matcher, guard-root updates, scope record, embedding-model changes in both bui…

---

Full details: Docstring Coverage

Explanation

Docstring coverage is 36.36% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 6 files. (1 skipped: 1 unsupported.)

---

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

---

---

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[mrveiss]

Merge-gate review at 1b6ecea: approve, on top of the author's Sonnet gate. KNOWN_EMBEDDING_MODEL_PREFIXES is one list read by both is_embedding_model_id and the guard, with rerankers excluded. The #18345 fix is the single mypy_path line, pinned by a no-mypy_path contrast test. The floor is re-pinned mid-window. Queued for the next merge train.

[github-actions]

✅ SSOT Configuration Compliance: Passing

🎉 No new hardcoded values of either class — ssot and other both block.

Known backlog in pipeline-scripts/hardcoded_values_baseline.txt is suppressed and tracked in #14371.

[coderabbitai]

Actionable comments posted: 2

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Repository: mrveiss/AutoBot-AI/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 3deb7662-0a4f-4f6c-95b3-97b0abd8d639

📥 Commits

Reviewing files that changed from the base of the PR and between 13be1b4 and 1b6ecea.

📒 Files selected for processing (7)

• autobot-infrastructure/shared/scripts/populate_kb_chromadb.py
• autobot-infrastructure/shared/tools/index_documentation.py
• autobot_shared/embedding_model.py
• pyproject.toml
• repo_tests/embedding_model_literal_guard_18143_test.py
• repo_tests/mypy_enum_alias_resolution_18345_test.py
• repo_tests/reach_scope_claim_17844_test.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift

Check the embedding model recorded for each persistent collection. If the configured model changes after a collection has been populated, both scripts can write or query vectors using an incompatible embedding space. A dimension mismatch can reject writes; equal dimensions can conceal incorrect search results.

• autobot-infrastructure/shared/scripts/populate_kb_chromadb.py#L148-L148: check the autobot_docs collection’s recorded model before selecting it for indexing, and rebuild when the model differs.
• autobot-infrastructure/shared/tools/index_documentation.py#L375-L375: apply the same check to ChromaDBIndexer before upserts or searches.

📍 Affects 2 files

• autobot-infrastructure/shared/scripts/populate_kb_chromadb.py#L148-L148 (this comment)
• autobot-infrastructure/shared/tools/index_documentation.py#L375-L375

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

Set a timeout for the mypy subprocess.

If mypy stalls, this test waits indefinitely and can block the test run. Set a timeout on subprocess.run and handle subprocess.TimeoutExpired with a useful failure message. Based on learnings, process-spawning calls must have a timeout.

🧰 Tools

🪛 ast-grep (0.45.3)

[error] 35-50: Command coming from incoming request
Context: subprocess.run(
[
sys.executable,
"-m",
"mypy",
f"--config-file={config}",
"--follow-imports=silent",
f"--cache-dir={cwd / 'cache'}",
"alias.py",
],
cwd=cwd,
capture_output=True,
text=True,
encoding="utf-8",
check=False,
)
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').

(subprocess-from-request)

Source: Learnings