Repository navigation
debt(embedding): infra scripts and the NPU worker still hard-code nomic-embed-text outside the literal guard's roots #18382
Description
Parent: #18143. Follow-up to #18328.
Problem
#18328 widened the embedding-model literal guard (repo_tests/embedding_model_literal_guard_18143_test.py) to namespaced ids, the e5/gte/jina families and the two infra collection builders (autobot-infrastructure/shared/scripts/populate_kb_chromadb.py and autobot-infrastructure/shared/tools/index_documentation.py, now on active_embedding_model()). These infrastructure sites still hard-code nomic-embed-text outside the guard's roots:
| File | Kind |
|---|---|
autobot-infrastructure/shared/scripts/utilities/migrate_redis_to_chromadb.py:139 |
builds a collection |
autobot-infrastructure/shared/scripts/verify_knowledge_consistency.py:196, :243, :312, :336 |
queries collections |
autobot-infrastructure/shared/scripts/utilities/npu_worker.py |
NPU worker script |
autobot-infrastructure/shared/scripts/analysis/npu_performance_measurement.py, redis_final_analysis.py, redis_vector_analysis.py |
analysis scripts |
autobot-infrastructure/shared/scripts/ai-ml/optimize_llm_models.py |
model tooling |
autobot-npu-worker/ (the Windows app, about 8 files) |
the worker's own default |
The first two matter most. A builder or verifier on a hard-coded model disagrees with the index as soon as the configured embedding model changes (#18143). Locations are from an agent sweep and must be re-verified before acting.
Acceptance criteria
- Each site is classified per bug(kb): embedding cache key and generator resolve the embedding model from different config fields #18143's three-class rule (index-bound via
knowledge/index_embedding_space.py, active, or not-a-choice), with the reason. - Builders and verifiers read the right model (
active_embedding_model()or the index's recorded space), and the guard's roots cover them. - Not-a-choice sites (analysis scripts, the worker's bundled default) are recorded in the guard with their reason, or moved onto the SSOT accessor.
Activity