Repository navigation
refactor(regex): one slugify, one skills tokenizer and one word tokenizer, the no-op ANSI copy gone, and the dead command-utils template retired (#18093, #18124) - #18360
Merged
Conversation
…stripper, not a no-op copy (#18093)
…n template (#18124) The analyser embedded a 190-line copy of utils/command_utils.py as a string constant and wrote it to src/utils/command_utils_consolidated.py, a path that no longer exists. Nothing imports the output; every function in it already lives in the canonical module (CommandResult.to_dict covers the result shape, execute_command covers timeout/cwd/env); the only unmatched pieces (execution_time, a sync variant, two aliases) have no importers anywhere. Owner rule: useless code is removed. The test now guards that no generated copy returns as a string constant.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
✅ SSOT Configuration Compliance: Passing🎉 No new hardcoded values of either class — Known backlog in |
This was referenced Oct 12, 2026
This was referenced Oct 12, 2026
Merged
This was referenced Oct 12, 2026
This was referenced Oct 12, 2026
Merged
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
#18093 found six regex concepts, each forked across 2–8 files, with one fork a no-op copy. #18124 found a dead code-generation template. Both were finished from a local-only branch from 2026-10-10 and rebased onto current
main. Five of the six concepts had already landed onmain(ANSI, frontmatter, email/UUID, git ref, endpoint normaliser). This branch delivers the rest.What Changed
autobot_shared/slug.pysanitize_tokenwith explicit parameters (allowed set, replacement, collapse, case, cap). The 12 migrated sites are each pinned byte-identical to their old output (utils/slug_equivalence_18093_test.py). Sites that can't migrate are on the guard's reasoned allowlist.autobot_shared/text_tokens.py).HEAD; its output pathsrc/utils/doesn't exist, so it would have raised; and its purpose lives inutils/command_utils.py. A test (analyze_duplicates_template_18093_test.py) stops a generated copy coming back.markdown_reference_system.pyuses the onecontent_digest(byte-identical), and its queued guard entry is removed.main'sregex_concept_fork_guard_18093_test.pyis extended, not forked. It gains theword-tokenizerandchar-sanitizer-classconcepts with contrast fixtures and a non-vacuity test.Verification
reach_scope_claim_17844run alone: 10.agent_loop: 288 passed. Skills, encoding, tool-output-filter, MCP aggregation, prepared facts and markdown-reference: 388 passed.main's later edits tofingerprint.py(content_digest),analytics_infrastructure.py(CollectionEmbeddingSpace),natural_language_search.pyanddoc_indexer.pyare all kept; the branch adds only this intent.Closes #18093
Closes #18124
Refs #15722
Model Used
Claude Opus 5.5 (master session: brief, PR). Finished by a Claude Sonnet subagent; the original commits came from a subagent on 2026-10-10.
🤖 Generated with Claude Code