Skip to content

fix(ci): reconcile the dependabot train's ansible-floor-sync and CI pin fixes onto main (#16591) - #16636

Merged
mrveiss merged 2 commits into
mainfrom
fix-dependabot-train-reconciliation
Sep 13, 2026
Merged

mrveiss merged 2 commits into
mainfrom
fix-dependabot-train-reconciliation

Conversation

@mrveiss

@mrveiss mrveiss commented Sep 13, 2026 •

Copy link
Copy Markdown
Owner

Thinking Path

Fast-track base fix: main (tip b688b3e48, the dependabot train's 10th member landing) is red on two shards because the train's own vehicle CI caught two real cross-cutting issues during validation, and the fix commits for both were still sitting on the disposable vehicle branch when the members got merged -- the vehicle itself was never meant to merge, so its own fix commits needed to travel as this standalone PR, but that PR wasn't opened before the members landed. This closes that gap.

Both fixes were already verified against the combined vehicle tree before the members merged (the vehicle's own CI went fully green after these two commits landed on it) -- this PR is exactly those two commits, cherry-picked onto current main with no changes.

What Changed

Verification

  • Root-caused against main's actual two failing shards:
  • Both commits already ran green on the dependabot vehicle's own combined-tree CI before the vehicle's members were merged individually.
  • Pre-push hook (now pointed at origin/main) ran clean on this exact 5-file changeset.

Risks

Low -- pure version-pin/floor mirroring, no behavior change. Diff is exactly 5 lines across 5 files.

Model Used

Claude Sonnet 5 (claude-sonnet-5)

Issue Link

N/A -- CI base-fix for the dependabot train (#16591), no application issue.

Single-issue rationale

N/A -- this is the vehicle's own reconciliation, finishing the existing train per merge-all-first.

Changelog fragment

  • N/A -- dependency-floor/CI-pin fixes, not user-facing.

Checklist

  • Code follows AutoBot patterns from CLAUDE.md
  • Tests added or updated (N/A -- existing ansible_requirements_parity_test.py and check_dependency_floors.py --strict are the tests this fixes)
  • Documentation updated if behavior changed (N/A)
  • Pre-commit hooks pass
  • PR targets main
  • No secrets or credentials in the diff

…manifests (#16591)

Vehicle CI (python-suite shard 8/12) caught a real cross-manifest
divergence exposed by combining this train's members, not a conflict
between two members: three ansible-side hardcoded floors fell behind
the manifest versions several dependabot bumps together moved forward,
and ansible_requirements_parity_test.py exists precisely to catch this
drift regardless of source (dependabot or human).

- roles/ai-stack/tasks/main.yml: transformers>=5.16.1 -> >=5.17.0,
  matching requirements-ai.txt (#16585's bump).
- roles/dependency_patching/defaults/main.yml: langchain-core
  1.6.1,<2.0.0 -> 1.6.2,<2.0.0 and pypdf 6.17.0 -> 6.18.0, matching
  what every manifest in the tree now states (#16572/#16574/#16584/
  #16586's bumps).

Verified directly: both previously-failing tests
(test_the_pre_15623_ai_stack_floors_are_a_regression_case,
test_every_cross_manifest_divergence_is_in_the_baseline) now pass when
called directly against the fixed tree.

This fix travels as its own standalone PR (not part of any dependabot
member's own diff, and the vehicle itself never merges) so it lands on
main alongside the members it makes consistent with.
…tions (#16591)

check_dependency_floors.py --strict failed in CI (not the local
advisory pre-push version): three CI-installed exact pins had fallen
behind the floor autobot-backend/requirements.txt or requirements.txt
declares, on unrelated main changes this vehicle's fresh-main merge
first exposed together:

- alembic 1.19.1 -> 1.19.2 (autobot-backend/requirements.txt:21)
- anthropic 1.3.0 -> 1.4.0 (autobot-backend/requirements.txt:40)
- pypdf 6.17.0 -> 6.18.0 (requirements.txt:43)

websockets also printed in the report but is a named, non-gating
KNOWN_CROSS_VENV_EXEMPTIONS entry (#16394) -- left untouched.
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ce7ad2d5-9daa-45d8-a488-76706735c0e0


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ SSOT Configuration Compliance: Passing

🎉 No new hardcoded values of either class — ssot and other both block.

Known backlog in pipeline-scripts/hardcoded_values_baseline.txt is suppressed and tracked in #14371.

@github-actions

Copy link
Copy Markdown
Contributor

Notice: 29 open PRs — past the runaway threshold (25)

There is no PR queue limit, and this is not a request to defer this PR. Work proceeds one issue at a time without a cap on open PRs; review capacity is the constraint.

This notice only means the count is high enough to be worth a glance for a runaway — something opening PRs in a loop, or a merge pipeline that has stalled so nothing is draining.

Currently open:

If the queue is draining normally, ignore this. Otherwise:

  1. Check whether CI is dispatching at all — see the ci-dispatch-watchdog status on these PRs
  2. Merge the ones whose CI has finished and review has passed: gh pr merge <number> --squash --delete-branch
  3. Look for a loop opening near-identical PRs

Warn-only runaway detector — .github/workflows/pr-queue-gate.yml. It never blocks a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant