Repository navigation
tech-debt(frontend): move SettingsPanel's detailed system health and Redis service management into the SLM #16245
Description
Activity
Pre-check for the stray patch, which #16252's fold removes. I read it from base
d5a0c6dcband executed nothing.autobot-frontend/src/components/SettingsPanel.vue.patchis 12 lines from #926. Its one addition inserts a{ id: 'notifications', label: 'Notifications' }tab into the oldautobot-vueSettingsPanel tab list;developeris only a context line.That capability has landed. The live settings UI,
views/SettingsView.vue:92-96, has anotificationstab ($t('settings.notifications')) that rendersPushNotificationSettingsPanel.vue. The currentcomponents/settings/SettingsPanel.vuehas noid:tab list at all, and nothing renders it.Nothing references the .patch, so the #16245 + #16252 PR deletes it.
- added a commit that references this issue
on Sep 11, 2026 - added 20 commits that reference this issue
on Sep 12, 2026 Closure audit (batch vehicle #16702, merge 28228ac). No checkbox ACs on either issue — verified against what each asks for.
Both folded into one PR (#16352) per the owner's 2026-09-11 decision recorded on #16252, which also changed the design mid-flight (option b: the SLM's own node-service API, not the main backend's
redis_servicemodel).Ask Verdict Evidence #16245: relocate detailed health + Redis control into the SLM met autobot-frontend/src/components/settings/SettingsPanel.vueno longer referenceshealth/detailed/DetailedHealthReport;autobot-slm-frontend/src/views/monitoring/admin/AdminMonitoringView.vuecovers it (/system/health/detailed, line 88)#16245: re-wire router/nav/i18n in the SLM met autobot-slm-frontend/src/views/OrchestrationView.vue:51,1174imports and rendersRedisServicePanel;autobot-slm-frontend/src/locales/en.jsoncarries theredisServicePaneli18n namespace#16245: remove user-GUI entry points met RedisServiceControl.vue,useServiceManagement.ts,RedisServiceAPI.ts, their spec,redis_service_api_integration_test.py, andSettingsPanel.vue.patchare all absent from origin/main (git showconfirms each path no longer exists)#16252: wire it (stop the 404s) met The 404ing client is deleted, not patched; the live SLM panel is wired to GET/POST /nodes/{id}/services...(RedisServicePanel.vue:11-13)#16252: add /healthroutemet (superseded) Only the unreachable client needed it; the live panel uses the node-services status/action routes instead #16252: type responses from backend models met RedisServicePanel.vue:284,366readsservice.main_pid/service.last_checked, matching the node-services payload it actually calls, with unknown fields shown as unknown per the design note in the mrveiss@2026-09-11T14:51:05Z comment on #16252#16252: sequence with #16245 met Same PR All asks delivered as amended by the owner's own recorded decision. Kept closed.
Owner rule (2026-09-10): deep settings belong in the SLM, and the user GUI keeps user-facing features. This is a sibling of #12637, which moves
ProviderFallbackViewandSystemHealthViewthe same way.Two deep-settings surfaces still live in
autobot-frontend:components/settings/SettingsPanel.vuefetches the admin-only/system/health/detailedreport and passes it to its child views. Since Cross-GUI type-name collisions beyond #14908's sweep: HealthStatus (x3), ServiceHealth, ServiceStatus #15401 that report is typedDetailedHealthReport.composables/useServiceManagement.ts, throughservices/RedisServiceAPI.ts, drives Redis service status, health and control.#15401 renamed the types behind both surfaces so they no longer collide with the SLM's
HealthStatus/ServiceHealth/ServiceStatus. This issue covers the move itself:Refs #15401, #12637.